fix: truncate overlay list rows to the item area (#504)

RenderOverlayList reserved a scrollbar column when the list overflows
but never truncated rows, so a row filling the caller's full innerW
budget (e.g. a multi-KB annotation value in the copy-field picker)
exceeded the box content width, wrapped onto a second line, and pushed
every row below out of sync with the per-row scrollbar glyphs. The
component now owns the no-wider-than-innerW invariant: non-cursor rows
truncate to the item area and the cursor row to its highlight width
(which would otherwise wrap inside the Width block). Fixes the same
latent overflow in the Object Explorer find overlay.

Author: janosmiko

internal/ui/overlay_list.go

@@ -207,16 +207,22 @@ func RenderOverlayList(items []OverlayListItem, cfg OverlayListConfig, innerW in
 			// so they stay readable against the box. CursorHighlightWidth
 			// caps the highlight short of the item area; the remainder pads
 			// with the surface background so the badge column stays put.
+			// Text is truncated to the highlight width — anything longer
+			// would wrap inside the Width(hlW) block, pushing every row
+			// below out of sync with the scrollbar column.
 			hlW := itemWidth
 			if cfg.CursorHighlightWidth > 0 && cfg.CursorHighlightWidth < itemWidth {
 				hlW = cfg.CursorHighlightWidth
 			}
-			row = OverlaySelectedStyle.Width(hlW).Render(itemPlainLine(it, cfg, hasActive))
+			row = OverlaySelectedStyle.Width(hlW).Render(Truncate(itemPlainLine(it, cfg, hasActive), hlW))
 			if pad := itemWidth - lipgloss.Width(row); pad > 0 {
 				row += OverlayDimStyle.Render(strings.Repeat(" ", pad))
 			}
 		} else {
-			line := OverlayNormalStyle.Render(itemStyledLine(it, cfg, hasActive))
+			// Truncated to the item area for the same reason as the cursor
+			// row: the component owns the no-wider-than-innerW invariant;
+			// callers only best-effort their Name/Description budgets.
+			line := OverlayNormalStyle.Render(Truncate(itemStyledLine(it, cfg, hasActive), itemWidth))
 			// Only pad non-cursor rows when there's a trailing column
 			// (badge or scrollbar) that needs a stable left edge —
 			// padding rows without a reserve regresses the historical

internal/ui/overlay_list_test.go

@@ -388,3 +388,64 @@ func TestRenderOverlayList(t *testing.T) {
 		assert.Contains(t, out, "Stale")
 	})
 }
+
+// --- row width invariant ---
+
+// Rows must never exceed innerW, no matter how long a caller-supplied
+// Name/Description is — an overlong row wraps inside the overlay box,
+// shifting every row below it and desyncing the per-row scrollbar
+// (observed with multi-KB annotation values in the copy-field picker).
+func TestRenderOverlayList_RowsNeverExceedInnerWidth(t *testing.T) {
+	long := strings.Repeat("x", 300)
+	mk := func(n int) []OverlayListItem {
+		items := make([]OverlayListItem, n)
+		for i := range items {
+			items[i] = OverlayListItem{Name: long, Description: long}
+		}
+		return items
+	}
+	const innerW = 80
+
+	t.Run("overflowing list with scrollbar", func(t *testing.T) {
+		cfg := OverlayListConfig{
+			Title:           "T",
+			Cursor:          2,
+			ShowDescription: true,
+			MaxVisible:      5,
+		}
+		out := RenderOverlayList(mk(20), cfg, innerW)
+		for i, line := range strings.Split(out, "\n") {
+			require.LessOrEqualf(t, lipgloss.Width(line), innerW,
+				"line %d wider than innerW", i)
+		}
+	})
+
+	t.Run("short list without scrollbar", func(t *testing.T) {
+		cfg := OverlayListConfig{Cursor: 0, ShowDescription: true}
+		out := RenderOverlayList(mk(3), cfg, innerW)
+		for i, line := range strings.Split(out, "\n") {
+			require.LessOrEqualf(t, lipgloss.Width(line), innerW,
+				"line %d wider than innerW", i)
+		}
+	})
+
+	t.Run("cursor row with badge and multiselect", func(t *testing.T) {
+		items := mk(12)
+		for i := range items {
+			items[i].Selected = i%2 == 0
+			items[i].Badge = "##"
+		}
+		cfg := OverlayListConfig{
+			Cursor:          4,
+			MultiSelect:     true,
+			ShowDescription: true,
+			MaxVisible:      6,
+			BadgeWidth:      2,
+		}
+		out := RenderOverlayList(items, cfg, innerW)
+		for i, line := range strings.Split(out, "\n") {
+			require.LessOrEqualf(t, lipgloss.Width(line), innerW,
+				"line %d wider than innerW", i)
+		}
+	})
+}