refactor(validate): switch from YAML to registry-based validation#943
Merged
refactor(validate): switch from YAML to registry-based validation#943
Conversation
…ation The validate/verify commands only scanned YAML files, which are no longer supported. Rewrite to validate commands from the in-memory registry populated by discoverClis(), aligning with the JS-first adapter architecture. New checks: missing description, browser commands without domain, pipeline step name typos, commands without func/pipeline, duplicate arg names, and positional arg ordering.
Manifest-registered commands have _lazy=true and no func/pipeline until execution time. Recognize this as a valid execution form.
- Emit warning when registry is empty instead of silent PASS - Resolve alias targets to canonical key before filtering
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
opencli validateandopencli verifyto use the in-memory registry instead of scanning YAML filesContext
Part of the JS-first alignment work identified in #942 review. The validate/verify commands were still scanning for
.yaml/.ymlfiles while all adapters have migrated to JavaScript.Test plan
npx tsc --noEmitpassesnpm test— 594 tests passopencli validateruns against registry and reports PASSopencli validate hackernewsfilters by siteopencli validate hackernews/topfilters by command