fix(weread/book): add fallback selectors for reader page without cover#1138
Merged
jackwener merged 3 commits intojackwener:mainfrom Apr 22, 2026
Merged
Conversation
When the private API session expires, `loadReaderFallbackResult` navigates to the reader URL. The page now sometimes skips the cover/flyleaf and renders reading content directly, causing the wait for cover/flyleaf title selectors to time out. - Add `.readerTopBar_title_link` to `page.wait` selector (always present) - Use cascading `firstText()` for title: cover → flyleaf → outline → top bar - Use cascading `firstText()` for author: cover → flyleaf → outline → document.title Fixes jackwener#1137 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
loadReaderFallbackResultnavigates to the reader URL. The page now sometimes skips the cover/flyleaf and renders reading content directly, causingpage.waitfor.horizontalReaderCoverPage_content_bookTitle/.wr_flyleaf_page_bookInfo_bookTitleto time out..readerTopBar_title_linkto the wait selector (always present in the top bar)firstText()for title/author extraction: cover → flyleaf → outline panel → top bar →document.titleparsingTest plan
opencli weread book 31732574— previously crashed withSELECTORerror, now returns title + authorFixes #1137
🤖 Generated with Claude Code