Skip to content

Commit a17ceac

Browse files
committed
docs(release): point to source files for Node versions
Stop hardcoding specific Node versions in the runbook. Reference the authoritative sources instead — `engines.node` in package.json for the minimum and the `node:` matrix in ci.yml (plus `node-version` in cd.yml) for the versions CI exercises — so the doc stays correct when CI's Node versions change without a separate edit.
1 parent d8f807b commit a17ceac

1 file changed

Lines changed: 6 additions & 4 deletions

File tree

.github/RELEASING.md

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -101,10 +101,12 @@ Requirements for `--create-release github` to work in CI:
101101
## 4. Pre-publish validation (always, but especially after the Lerna upgrade)
102102

103103
These steps are **cross-platform** — every command is `npm`/`npx`-based and runs
104-
identically in PowerShell, `cmd`, bash, and zsh (Windows and macOS). **Node 18+
105-
is required** — enforced via each package's `engines.node` (`>=18.0.0`). CI runs
106-
Node 18.x and 20.x (see `cd.yml`/`ci.yml`), and the jest 29 toolchain also runs
107-
green on Node 24.
104+
identically in PowerShell, `cmd`, bash, and zsh (Windows and macOS). For the Node
105+
version, don't rely on a number hardcoded here: the minimum is enforced by
106+
`engines.node` in each `package.json`, and the versions CI exercises are the
107+
`node:` matrix in [`ci.yml`](workflows/ci.yml) (the publish job pins its own under
108+
`node-version` in [`cd.yml`](workflows/cd.yml)). Use a version that satisfies both
109+
— checking those files keeps this runbook correct as the supported versions change.
108110

109111
> **Order matters.** This is a `lerna bootstrap` monorepo: per-package
110112
> devDependencies (including `@types/node`) are installed and hoisted by

0 commit comments

Comments
 (0)