Skip to content

feat: [css] new module for css#10212

Merged
ddixit14 merged 4 commits into
mainfrom
new_module_java-shopping-css-new-module
Jan 10, 2024
Merged

feat: [css] new module for css#10212
ddixit14 merged 4 commits into
mainfrom
new_module_java-shopping-css-new-module

Conversation

@ddixit14

@ddixit14 ddixit14 commented Jan 9, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

python3.9 generation/new_client/new-client.py generate
--api_shortname=css
--proto-path=google/shopping/css
--name-pretty="CSS API"
--product-docs="https://developers.google.com/comparison-shopping-services/api"
--api-description="The CSS API is used to manage your CSS and control your CSS Products portfolio"
--distribution-name="com.google.shopping:google-shopping-css"
--destination-name=shopping-css

@ddixit14 ddixit14 requested a review from a team January 9, 2024 20:13
@snippet-bot

snippet-bot Bot commented Jan 9, 2024 •
edited
Loading

Copy link
Copy Markdown

Here is the summary of changes.

You are about to add 64 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@suztomo

suztomo commented Jan 10, 2024 •
edited
Loading

Copy link
Copy Markdown
Member

"ci / gapic-libraries-bom"
https://github.com/googleapis/google-cloud-java/actions/runs/7466430488/job/20317772295?pr=10212 failed

2024-01-09T20:28:07.5737592Z [ERROR] Failed to execute goal org.apache.maven.plugins:maven-enforcer-plugin:3.4.1:enforce (enforce) on project grpc-google-shopping-css-v1: 
2024-01-09T20:28:07.5738413Z [ERROR] Rule 3: org.codehaus.mojo.extraenforcer.dependencies.BanDuplicateClasses failed with message:
2024-01-09T20:28:07.5738606Z [ERROR] Duplicate classes found:
2024-01-09T20:28:07.5738739Z [ERROR] 
2024-01-09T20:28:07.5738895Z [ERROR]   Found in:
2024-01-09T20:28:07.5739621Z [ERROR]     com.google.shopping.api.grpc:proto-google-shopping-css-v1:jar:0.0.1-SNAPSHOT:compile
2024-01-09T20:28:07.5740153Z [ERROR]     com.google.api.grpc:proto-google-common-protos:jar:2.30.0:compile
2024-01-09T20:28:07.5740334Z [ERROR]   Duplicate classes:
2024-01-09T20:28:07.5740742Z [ERROR]     com/google/api/MethodSettings$LongRunningOrBuilder.class
2024-01-09T20:28:07.5740942Z [ERROR]     com/google/api/Usage$1.class
2024-01-09T20:28:07.5741141Z [ERROR]     com/google/api/Logging.class
2024-01-09T20:28:07.5741463Z [ERROR]     com/google/api/AuthProvider$1.class
2024-01-09T20:28:07.5741780Z [ERROR]     com/google/api/ProjectProperties$Builder.class
2024-01-09T20:28:07.5742051Z [ERROR]     com/google/api/DocumentationProto.class
2024-01-09T20:28:07.5742268Z [ERROR]     com/google/api/JwtLocation.class
...

@suztomo

suztomo commented Jan 10, 2024 •
edited
Loading

Copy link
Copy Markdown
Member

The generated files contain unwanted files in com.google.api package:

image

com.google.shopping package is good but the library should not contain com.google.api package.

For comparison, here is the other shopping modules are structured:

image

@ddixit14 ddixit14 merged commit 618344a into main Jan 10, 2024
@ddixit14 ddixit14 deleted the new_module_java-shopping-css-new-module branch January 10, 2024 18:21
@release-please release-please Bot mentioned this pull request Jan 10, 2024
Merged
@diegomarquezp diegomarquezp restored the new_module_java-shopping-css-new-module branch January 15, 2024 22:14
@suztomo suztomo mentioned this pull request Jan 23, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@suztomo suztomo suztomo approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ddixit14 @suztomo