PUBLIC: Flag obsolete Scanner constructors in JdkObsolete.

RELNOTES=n/a
PiperOrigin-RevId: 864840303

Author: kluever

core/src/main/java/com/google/errorprone/bugpatterns/JdkObsolete.java

@@ -199,6 +199,26 @@ private record ObsoleteApi(Matcher<ExpressionTree> matcher, String message) {}
 
   private static final ImmutableList<ObsoleteApi> OBSOLETE_CONSTRUCTORS =
       ImmutableList.of(
+          new ObsoleteApi(
+              constructor()
+                  .forClass("java.util.Scanner")
+                  .withParameters("java.io.InputStream", "java.lang.String"),
+              "Use new Scanner(InputStream, Charset) instead."),
+          new ObsoleteApi(
+              constructor()
+                  .forClass("java.util.Scanner")
+                  .withParameters("java.io.File", "java.lang.String"),
+              "Use new Scanner(File, Charset) instead."),
+          new ObsoleteApi(
+              constructor()
+                  .forClass("java.util.Scanner")
+                  .withParameters("java.nio.file.Path", "java.lang.String"),
+              "Use new Scanner(Path, Charset) instead."),
+          new ObsoleteApi(
+              constructor()
+                  .forClass("java.util.Scanner")
+                  .withParameters("java.nio.channels.ReadableByteChannel", "java.lang.String"),
+              "Use new Scanner(ReadableByteChannel, Charset) instead."),
           new ObsoleteApi(
               constructor()
                   .forClass("java.lang.String")

core/src/test/java/com/google/errorprone/bugpatterns/JdkObsoleteTest.java

@@ -411,6 +411,7 @@ public void preferCharsetAcceptingApis() {
             import java.io.*;
             import java.net.*;
             import java.nio.channels.*;
+            import java.nio.file.Path;
             import java.util.*;
 
             class Test {
@@ -495,6 +496,18 @@ void properties(OutputStream os) throws Exception {
                 // BUG: Diagnostic contains: Properties.storeToXML(OutputStream, String, Charset)
                 new Properties().storeToXML(os, "comment", UTF8_NAME);
               }
+
+              void scanner(InputStream is, String fileName, File file, Path path, ReadableByteChannel rbc)
+                  throws Exception {
+                // BUG: Diagnostic contains: new Scanner(InputStream, Charset)
+                new Scanner(is, UTF8_NAME);
+                // BUG: Diagnostic contains: new Scanner(File, Charset)
+                new Scanner(file, UTF8_NAME);
+                // BUG: Diagnostic contains: new Scanner(Path, Charset)
+                new Scanner(path, UTF8_NAME);
+                // BUG: Diagnostic contains: new Scanner(ReadableByteChannel, Charset)
+                new Scanner(rbc, UTF8_NAME);
+              }
             }
             """)
         .doTest();