chore: ty does not need to run using tox

hkad98 · hkad98 · commit da602ace0a61 · 2026-02-17T20:02:07.000+01:00
`ty` chooses Python version based on pyproject.toml, no need to use `tox`.

JIRA: TRIVIAL
risk: low
diff --git a/packages/gooddata-dbt/pyproject.toml b/packages/gooddata-dbt/pyproject.toml
@@ -40,10 +40,6 @@ test = [
     "pytest-cov~=6.0.0",
     "pytest-json-report==1.5.0",
 ]
-type = [
-    "mypy~=1.11.2",
-    "pydantic~=2.12.0",
-]
 
 [tool.ty.analysis]
 allowed-unresolved-imports = ["deep_translator", "github"]
diff --git a/packages/gooddata-dbt/tox.ini b/packages/gooddata-dbt/tox.ini
@@ -12,11 +12,3 @@ setenv =
     COVERAGE_CORE=sysmon
 commands =
     pytest -v --cov=src/gooddata_dbt --cov-report=xml tests {posargs} --json-report --json-report-file=.json-report-{envname}.json
-
-[testenv:type-check]
-runner = uv-venv-lock-runner
-skip_install = true
-dependency_groups =
-    type
-commands =
-    uv run ty check src/gooddata_dbt
diff --git a/packages/gooddata-fdw/pyproject.toml b/packages/gooddata-fdw/pyproject.toml
@@ -58,10 +58,6 @@ test = [
     "pyyaml",
     "tests_support",
 ]
-type = [
-    "mypy~=1.11.2",
-    "pydantic~=2.12.0",
-]
 
 [tool.ty.analysis]
 allowed-unresolved-imports = ["multicorn"]
diff --git a/packages/gooddata-fdw/tox.ini b/packages/gooddata-fdw/tox.ini
@@ -13,14 +13,6 @@ setenv =
 commands =
     pytest -v --cov=src/gooddata_fdw --cov-report=xml tests {posargs} --json-report --json-report-file=.json-report-{envname}.json
 
-[testenv:type-check]
-runner = uv-venv-lock-runner
-skip_install = true
-dependency_groups =
-    type
-commands =
-    uv run ty check src/gooddata_fdw
-
 [testenv:docs]
 basepython = python3.14
 skip_install = true
diff --git a/packages/gooddata-flexconnect/pyproject.toml b/packages/gooddata-flexconnect/pyproject.toml
@@ -60,10 +60,6 @@ test = [
     "pytest-cov~=6.0.0",
     "pytest-json-report==1.5.0",
 ]
-type = [
-    "mypy~=1.11.2",
-    "pydantic~=2.12.0",
-]
 
 [tool.ty.analysis]
 allowed-unresolved-imports = ["jsonschema.**", "referencing"]
diff --git a/packages/gooddata-flexconnect/tox.ini b/packages/gooddata-flexconnect/tox.ini
@@ -13,14 +13,6 @@ setenv =
 commands =
     pytest -v --cov=src/gooddata_flexconnect --cov-report=xml tests {posargs} --json-report --json-report-file=.json-report-{envname}.json
 
-[testenv:type-check]
-runner = uv-venv-lock-runner
-skip_install = true
-dependency_groups =
-    type
-commands =
-    uv run ty check src/gooddata_flexconnect
-
 [testenv:docs]
 basepython = python3.14
 skip_install = true
diff --git a/packages/gooddata-flight-server/pyproject.toml b/packages/gooddata-flight-server/pyproject.toml
@@ -64,10 +64,6 @@ test = [
     "pytest-cov~=6.0.0",
     "pytest-json-report==1.5.0",
 ]
-type = [
-    "mypy~=1.11.2",
-    "pydantic~=2.12.0",
-]
 
 [tool.ty.analysis]
 allowed-unresolved-imports = [
diff --git a/packages/gooddata-flight-server/tox.ini b/packages/gooddata-flight-server/tox.ini
@@ -13,14 +13,6 @@ setenv =
 commands =
     pytest -v --cov=src/gooddata_flight_server --cov-report=xml tests {posargs} --json-report --json-report-file=.json-report-{envname}.json
 
-[testenv:type-check]
-runner = uv-venv-lock-runner
-skip_install = true
-dependency_groups =
-    type
-commands =
-    uv run ty check src/gooddata_flight_server
-
 [testenv:docs]
 basepython = python3.14
 skip_install = true
diff --git a/packages/gooddata-pandas/pyproject.toml b/packages/gooddata-pandas/pyproject.toml
@@ -64,10 +64,6 @@ test = [
     "pyyaml",
     "tests_support",
 ]
-type = [
-    "mypy~=1.11.2",
-    "pydantic~=2.12.0",
-]
 
 [tool.ty.analysis]
 allowed-unresolved-imports = ["gooddata_api_client"]
diff --git a/packages/gooddata-pandas/tox.ini b/packages/gooddata-pandas/tox.ini
@@ -13,14 +13,6 @@ setenv =
 commands =
     pytest -v --cov=src/gooddata_pandas --cov-report=xml tests {posargs} --json-report --json-report-file=.json-report-{envname}.json
 
-[testenv:type-check]
-runner = uv-venv-lock-runner
-skip_install = true
-dependency_groups =
-    type
-commands =
-    uv run ty check src/gooddata_pandas
-
 [testenv:docs]
 basepython = python3.14
 skip_install = true
diff --git a/packages/gooddata-pipelines/pyproject.toml b/packages/gooddata-pipelines/pyproject.toml
@@ -19,12 +19,6 @@ dependencies = [
     "types-pyyaml (>=6.0.12.20250326,<7.0.0)",
 ]
 
-[tool.mypy]
-disallow_untyped_defs = true
-warn_redundant_casts = true
-strict_equality = true
-no_implicit_optional = true
-
 [tool.ruff]
 exclude = [".venv"]
 line-length = 80
@@ -38,10 +32,9 @@ test = [
     "moto (>=5.1.6,<6.0.0)",
     "orjson (>=3.11.3,<4.0.0)",
 ]
-type = [
-    "mypy (>=1.11.2,<2.0.0)",
-    "pydantic~=2.12.0",
-]
+
+[tool.ty.analysis]
+allowed-unresolved-imports = ["boto3.**", "botocore.**", "mypy_boto3_s3.**", "azure.**"]
 
 [build-system]
 requires = ["hatchling"]
diff --git a/packages/gooddata-pipelines/tox.ini b/packages/gooddata-pipelines/tox.ini
@@ -12,11 +12,3 @@ setenv =
     COVERAGE_CORE=sysmon
 commands =
     pytest -v --cov=src/gooddata_pipelines --cov-report=xml tests {posargs} --json-report --json-report-file=.json-report-{envname}.json
-
-[testenv:type-check]
-runner = uv-venv-lock-runner
-skip_install = true
-dependency_groups =
-    type
-commands =
-    uv run ty check src/gooddata_pipelines
diff --git a/packages/gooddata-sdk/pyproject.toml b/packages/gooddata-sdk/pyproject.toml
@@ -69,14 +69,6 @@ test = [
     "deepdiff~=8.5.0",
     "tests_support",
 ]
-type = [
-    "mypy~=1.11.2",
-    "pydantic~=2.12.0",
-    "types-python-dateutil >= 2.5.3",
-    "types-pyyaml~=6.0.0",
-    "attrs>=21.4.0,<=24.2.0",
-    "cattrs>=22.1.0,<=24.1.1",
-]
 
 [tool.ty.analysis]
 allowed-unresolved-imports = ["gooddata_api_client.**"]
diff --git a/packages/gooddata-sdk/tox.ini b/packages/gooddata-sdk/tox.ini
@@ -13,14 +13,6 @@ setenv =
 commands =
     pytest -v --cov=src/gooddata_sdk --cov-report=xml tests {posargs} --json-report --json-report-file=.json-report-{envname}.json
 
-[testenv:type-check]
-runner = uv-venv-lock-runner
-skip_install = true
-dependency_groups =
-    type
-commands =
-    uv run ty check src/gooddata_sdk
-
 [testenv:docs]
 basepython = python3.14
 skip_install = true
diff --git a/project_common.mk b/project_common.mk
@@ -3,6 +3,8 @@
 # Common command components (run from workspace root, scoped to this package)
 ROOT_DIR = ../..
 RUFF = ./.venv/bin/ruff
+# ty needs uv run (unlike ruff) because it resolves imports from installed packages
+TY = uv run ty
 PKG_PATH = packages/$(CURR_DIR_BASE_NAME)
 
 TOX_FLAGS =
@@ -50,7 +52,7 @@ format-diff:
 
 .PHONY: type-check
 type-check:
-	uv run tox $(TOX_FLAGS) -e type-check
+	(cd $(ROOT_DIR); $(TY) check --project $(PKG_PATH) $(PKG_PATH)/src)
 
 .PHONY: types
 types: type-check
diff --git a/pyproject.toml b/pyproject.toml
@@ -43,7 +43,7 @@ lint = [
     "ruff==0.9.5",
 ]
 type = [
-    "ty>=0.0.14",
+    "ty~=0.0.14",
 ]
 test = [
     # Common test dependencies used across all workspace packages
diff --git a/uv.lock b/uv.lock
