Skip to content

Commit 32edef8

Browse files
authored
feat(filter): review request type (user or team) (#3023)
Signed-off-by: Adam Setch <adam.setch@outlook.com>
1 parent b87cc77 commit 32edef8

18 files changed

Lines changed: 836 additions & 8 deletions

File tree

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,14 @@
1+
import { renderWithProviders } from '../../__helpers__/test-utils';
2+
import { mockMultipleAccountNotifications } from '../../__mocks__/notifications-mocks';
3+
4+
import { ReviewRequestTypeFilter } from './ReviewRequestTypeFilter';
5+
6+
describe('renderer/components/filters/ReviewRequestTypeFilter.tsx', () => {
7+
it('should render itself & its children', () => {
8+
const tree = renderWithProviders(<ReviewRequestTypeFilter />, {
9+
notifications: mockMultipleAccountNotifications,
10+
});
11+
12+
expect(tree.container).toMatchSnapshot();
13+
});
14+
});
Lines changed: 24 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,24 @@
1+
import type { FC } from 'react';
2+
3+
import { GitPullRequestIcon } from '@primer/octicons-react';
4+
import { Text } from '@primer/react';
5+
6+
import { reviewRequestTypeFilter } from '../../utils/notifications/filters';
7+
import { FilterSection } from './FilterSection';
8+
9+
export const ReviewRequestTypeFilter: FC = () => {
10+
return (
11+
<FilterSection
12+
filter={reviewRequestTypeFilter}
13+
filterSetting="reviewRequestTypes"
14+
icon={GitPullRequestIcon}
15+
id="filter-review-request-types"
16+
title="Review Request Type"
17+
tooltip={
18+
<Text>
19+
Filter review requests by whether you were directly requested or requested via a team.
20+
</Text>
21+
}
22+
/>
23+
);
24+
};

src/renderer/components/filters/__snapshots__/ReviewRequestTypeFilter.test.tsx.snap

Lines changed: 195 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/renderer/routes/Filters.tsx

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@ import { useFiltersStore } from '../stores';
88

99
import { AccountFilter } from '../components/filters/AccountFilter';
1010
import { ReasonFilter } from '../components/filters/ReasonFilter';
11+
import { ReviewRequestTypeFilter } from '../components/filters/ReviewRequestTypeFilter';
1112
import { SearchFilter } from '../components/filters/SearchFilter';
1213
import { StateFilter } from '../components/filters/StateFilter';
1314
import { SubjectTypeFilter } from '../components/filters/SubjectTypeFilter';
@@ -36,6 +37,7 @@ export const FiltersRoute: FC = () => {
3637
<UserTypeFilter />
3738
<SubjectTypeFilter />
3839
<StateFilter />
40+
<ReviewRequestTypeFilter />
3941
<ReasonFilter />
4042
</Stack>
4143
</Contents>

0 commit comments

Comments
 (0)