-
Notifications
You must be signed in to change notification settings - Fork 164
Expand file tree
/
Copy pathtest_rails_controller_render_literal.rb
More file actions
468 lines (392 loc) · 13.4 KB
/
Copy pathtest_rails_controller_render_literal.rb
File metadata and controls
468 lines (392 loc) · 13.4 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
# frozen_string_literal: true
require_relative "cop_test"
require "minitest/autorun"
require "rubocop/cop/github/rails_controller_render_literal"
class TestRailsControllerRenderLiteral < CopTest
def cop_class
RuboCop::Cop::GitHub::RailsControllerRenderLiteral
end
def test_render_string_literal_class_name_no_offense
offenses = investigate cop, <<-RUBY, "app/controllers/products_controller.rb"
class ProductsController < ActionController::Base
def index
render(MyClass, title: "foo", bar: "baz")
end
end
RUBY
assert_equal 0, offenses.count
end
def test_render_string_literal_class_instance_no_offense
offenses = investigate cop, <<-RUBY, "app/controllers/products_controller.rb"
class ProductsController < ActionController::Base
def index
render(MyClass.new(title: "foo", bar: "baz"))
end
end
RUBY
assert_equal 0, offenses.count
end
def test_render_string_literal_module_class_name_no_offense
offenses = investigate cop, <<-RUBY, "app/controllers/products_controller.rb"
class ProductsController < ActionController::Base
def index
render(Module::MyClass, title: "foo", bar: "baz")
end
end
RUBY
assert_equal 0, offenses.count
end
def test_render_string_literal_module_class_instance_no_offense
offenses = investigate cop, <<-RUBY, "app/controllers/products_controller.rb"
class ProductsController < ActionController::Base
def index
render(Module::MyClass.new(title: "foo", bar: "baz"))
end
end
RUBY
assert_equal 0, offenses.count
end
def test_render_string_literal_module_class_name_block_no_offense
offenses = investigate cop, <<-RUBY, "app/controllers/products_controller.rb"
class ProductsController < ActionController::Base
def index
render(Module::MyClass.new(title: "foo", bar: "baz")) do
"my block content"
end
end
end
RUBY
assert_equal 0, offenses.count
end
def test_render_string_literal_action_name_no_offense
offenses = investigate cop, <<-RUBY, "app/controllers/products_controller.rb"
class ProductsController < ActionController::Base
def index
render "index"
end
end
RUBY
assert_equal 0, offenses.count
end
def test_render_sym_literal_action_name_no_offense
offenses = investigate cop, <<-RUBY, "app/controllers/products_controller.rb"
class ProductsController < ActionController::Base
def index
render :index
end
end
RUBY
assert_equal 0, offenses.count
end
def test_render_action_literal_action_name_no_offense
offenses = investigate cop, <<-RUBY, "app/controllers/products_controller.rb"
class ProductsController < ActionController::Base
def index
render action: :index
end
end
RUBY
assert_equal 0, offenses.count
end
def test_render_string_literal_full_template_name_no_offense
offenses = investigate cop, <<-RUBY, "app/controllers/products_controller.rb"
class ProductsController < ActionController::Base
def index
render "products/index"
end
end
RUBY
assert_equal 0, offenses.count
end
def test_render_template_literal_full_template_name_no_offense
offenses = investigate cop, <<-RUBY, "app/controllers/products_controller.rb"
class ProductsController < ActionController::Base
def index
render template: "products/index"
end
end
RUBY
assert_equal 0, offenses.count
end
def test_render_template_and_layout_literal_full_template_name_no_offense
offenses = investigate cop, <<-RUBY, "app/controllers/products_controller.rb"
class ProductsController < ActionController::Base
def index
render template: "products/index", layout: "layouts/products"
end
end
RUBY
assert_equal 0, offenses.count
end
def test_render_partial_literal_full_template_name_no_offense
offenses = investigate cop, <<-RUBY, "app/controllers/products_controller.rb"
class ProductsController < ActionController::Base
def index
render partial: "products/index"
end
end
RUBY
assert_equal 0, offenses.count
end
def test_render_partial_literal_full_template_name_and_no_layout_no_offense
offenses = investigate cop, <<-RUBY, "app/controllers/products_controller.rb"
class ProductsController < ActionController::Base
def index
render partial: "products/index", layout: false
end
end
RUBY
assert_equal 0, offenses.count
end
def test_render_dynamic_file_no_offense
offenses = investigate cop, <<-RUBY, "app/controllers/products_controller.rb"
class ProductsController < ActionController::Base
def index
render file: "\#{Rails.root}/public/404.html"
render file: "\#{Rails.root}/public/404.html", layout: false
end
end
RUBY
assert_equal 0, offenses.count
end
def test_render_inline_no_offense
offenses = investigate cop, <<-RUBY, "app/controllers/products_controller.rb"
class ProductsController < ActionController::Base
def index
render inline: "Hello <%= @name %>"
end
end
RUBY
assert_equal 0, offenses.count
end
def test_render_xml_no_offense
offenses = investigate cop, <<-RUBY, "app/controllers/products_controller.rb"
class ProductsController < ActionController::Base
def index
render xml: @product
end
end
RUBY
assert_equal 0, offenses.count
end
def test_render_json_no_offense
offenses = investigate cop, <<-RUBY, "app/controllers/products_controller.rb"
class ProductsController < ActionController::Base
def index
render json: @product
end
end
RUBY
assert_equal 0, offenses.count
end
def test_render_plain_no_offense
offenses = investigate cop, <<-RUBY, "app/controllers/products_controller.rb"
class ProductsController < ActionController::Base
def index
render plain: "OK"
end
end
RUBY
assert_equal 0, offenses.count
end
def test_render_html_no_offense
offenses = investigate cop, <<-RUBY, "app/controllers/products_controller.rb"
class ProductsController < ActionController::Base
def index
render html: "<strong>Not Found</strong>".html_safe
end
end
RUBY
assert_equal 0, offenses.count
end
def test_render_body_no_offense
offenses = investigate cop, <<-RUBY, "app/controllers/products_controller.rb"
class ProductsController < ActionController::Base
def index
render body: "raw"
end
end
RUBY
assert_equal 0, offenses.count
end
def test_render_nothing_no_offense
offenses = investigate cop, <<-RUBY, "app/controllers/products_controller.rb"
class ProductsController < ActionController::Base
def index
render nothing: true
end
end
RUBY
assert_equal 0, offenses.count
end
def test_render_implicit_offense
offenses = investigate cop, <<-RUBY, "app/controllers/products_controller.rb"
class ProductsController < ActionController::Base
def index
render
end
end
RUBY
assert_equal 1, offenses.count
assert_equal "#{cop.name}: render must be used with a string literal or an instance of a Class", offenses[0].message
end
def test_render_implicit_with_layout_offense
offenses = investigate cop, <<-RUBY, "app/controllers/products_controller.rb"
class ProductsController < ActionController::Base
def index
render layout: "layouts/product"
end
end
RUBY
assert_equal 1, offenses.count
assert_equal "#{cop.name}: render must be used with a string literal or an instance of a Class", offenses[0].message
end
def test_render_implicit_with_status_offense
offenses = investigate cop, <<-RUBY, "app/controllers/products_controller.rb"
class ProductsController < ActionController::Base
def index
render status: :ok
end
end
RUBY
assert_equal 1, offenses.count
assert_equal "#{cop.name}: render must be used with a string literal or an instance of a Class", offenses[0].message
end
def test_render_variable_offense
offenses = investigate cop, <<-RUBY, "app/controllers/products_controller.rb"
class ProductsController < ActionController::Base
def index
render magic_string
end
end
RUBY
assert_equal 1, offenses.count
assert_equal "#{cop.name}: render must be used with a string literal or an instance of a Class", offenses[0].message
end
def test_render_to_string_variable_offense
offenses = investigate cop, <<-RUBY, "app/controllers/products_controller.rb"
class ProductsController < ActionController::Base
def index
render_to_string(magic_string)
end
end
RUBY
assert_equal 1, offenses.count
assert_equal "#{cop.name}: render must be used with a string literal or an instance of a Class", offenses[0].message
end
def test_render_action_variable_offense
offenses = investigate cop, <<-RUBY, "app/controllers/products_controller.rb"
class ProductsController < ActionController::Base
def index
render action: magic_symbol
end
end
RUBY
assert_equal 1, offenses.count
assert_equal "#{cop.name}: render must be used with a string literal or an instance of a Class", offenses[0].message
end
def test_render_template_variable_offense
offenses = investigate cop, <<-RUBY, "app/controllers/products_controller.rb"
class ProductsController < ActionController::Base
def index
render template: magic_string
end
end
RUBY
assert_equal 1, offenses.count
assert_equal "#{cop.name}: render must be used with a string literal or an instance of a Class", offenses[0].message
end
def test_render_partial_variable_offense
offenses = investigate cop, <<-RUBY, "app/controllers/products_controller.rb"
class ProductsController < ActionController::Base
def index
render partial: magic_string
end
end
RUBY
assert_equal 1, offenses.count
assert_equal "#{cop.name}: render must be used with a string literal or an instance of a Class", offenses[0].message
end
def test_render_template_with_layout_variable_offense
offenses = investigate cop, <<-RUBY, "app/controllers/products_controller.rb"
class ProductsController < ActionController::Base
def index
render template: "products/index", layout: magic_string
end
end
RUBY
assert_equal 1, offenses.count
assert_equal "#{cop.name}: render must be used with a string literal or an instance of a Class", offenses[0].message
end
def test_render_template_variable_with_layout_offense
offenses = investigate cop, <<-RUBY, "app/controllers/products_controller.rb"
class ProductsController < ActionController::Base
def index
render template: magic_string, layout: "layouts/product"
end
end
RUBY
assert_equal 1, offenses.count
assert_equal "#{cop.name}: render must be used with a string literal or an instance of a Class", offenses[0].message
end
def test_render_shorthand_static_locals_no_offsense
offenses = investigate cop, <<-RUBY, "app/controllers/products_controller.rb"
class ProductsController < ActionController::Base
def index
render "products/index", locals: { product: product }
end
end
RUBY
assert_equal 0, offenses.count
end
def test_render_partial_static_locals_no_offsense
offenses = investigate cop, <<-RUBY, "app/controllers/products_controller.rb"
class ProductsController < ActionController::Base
def index
render partial: "products/index", locals: { product: product }
end
end
RUBY
assert_equal 0, offenses.count
end
def test_render_literal_dynamic_options_offense
offenses = investigate cop, <<-RUBY, "app/controllers/products_controller.rb"
class ProductsController < ActionController::Base
def index
render "products/product", options
end
end
RUBY
assert_equal 1, offenses.count
end
def test_render_literal_dynamic_locals_offense
offenses = investigate cop, <<-RUBY, "app/controllers/products_controller.rb"
class ProductsController < ActionController::Base
def index
render "products/product", locals: locals
end
end
RUBY
assert_equal 1, offenses.count
end
def test_render_literal_splat_locals_offense
offenses = investigate cop, <<-RUBY, "app/controllers/products_controller.rb"
class ProductsController < ActionController::Base
def index
render "products/product", locals: { **locals }
end
end
RUBY
assert_equal 1, offenses.count
end
def test_render_literal_dynamic_local_key_offense
offenses = investigate cop, <<-RUBY, "app/controllers/products_controller.rb"
class ProductsController < ActionController::Base
def index
render "products/product", locals: { product_key => product }
end
end
RUBY
assert_equal 1, offenses.count
end
end