Skip to content

Commit 1461106

Browse files
Copilotedburns
andauthored
Address review comments: node exit 0, pin setup-node SHA, update commit message
Agent-Logs-Url: https://github.com/github/copilot-sdk-java/sessions/a806a008-d6a9-4f91-9afd-746df3cc127a Co-authored-by: edburns <75821+edburns@users.noreply.github.com>
1 parent 227a563 commit 1461106

3 files changed

Lines changed: 3 additions & 3 deletions

File tree

.github/actions/setup-copilot/action.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ outputs:
1010
runs:
1111
using: "composite"
1212
steps:
13-
- uses: actions/setup-node@v6
13+
- uses: actions/setup-node@60edb5dd545a775178f52524783378180af0d1f8 # v6
1414
with:
1515
node-version: 22
1616
- name: Read pinned @github/copilot version from pom.xml

.github/scripts/reference-impl-sync/merge-reference-impl-finish.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,7 @@ echo "▸ Syncing @github/copilot version in pom.xml from reference implementati
5757
"$ROOT_DIR/.github/scripts/reference-impl-sync/sync-cli-version-from-reference-impl.sh" "$REFERENCE_IMPL_DIR"
5858

5959
git add .lastmerge pom.xml
60-
git commit -m "Update .lastmerge to $NEW_COMMIT"
60+
git commit -m "Update .lastmerge to $NEW_COMMIT and sync pom.xml CLI version"
6161

6262
# ── 3. Push branch ───────────────────────────────────────────
6363
echo "▸ Pushing branch $BRANCH_NAME to origin…"

.github/scripts/reference-impl-sync/sync-cli-version-from-reference-impl.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,7 @@ fi
5656

5757
# node is always available since the reference implementation uses npm.
5858
CLI_VERSION=$(node -e \
59-
"const fs=require('fs');const p=JSON.parse(fs.readFileSync(process.argv[1],'utf8'));const v=(p.dependencies&&p.dependencies['@github/copilot'])||(p.devDependencies&&p.devDependencies['@github/copilot']);if(!v){process.exit(2);}process.stdout.write(v);" \
59+
"const fs=require('fs');const p=JSON.parse(fs.readFileSync(process.argv[1],'utf8'));const v=(p.dependencies&&p.dependencies['@github/copilot'])||(p.devDependencies&&p.devDependencies['@github/copilot']);process.stdout.write(v||'');" \
6060
"$PKG_JSON")
6161

6262
if [[ -z "$CLI_VERSION" ]]; then

0 commit comments

Comments
 (0)