From c1dd4b121cd77fe8bad1bac014fd82a5268f5d17 Mon Sep 17 00:00:00 2001
From: Markus Stange <mstange.moz@gmail.com>
Date: Sun, 21 Jun 2026 10:49:01 -0400
Subject: [PATCH] Pass callNodeInfo to handleCallNodeTransformShortcut.

The function handleCallNodeTransformShortcut takes a call node index
as a parameter, but it was getting the call node info separately from
a selector. At the moment that's fine because this is always the right
call node info.

But once we add separate call node infos for things like "the callees
of the selected function in the function list", the two might get out
of sync, so it's better to pass the correct call node info that is
compatible with the passed call node index.

Functionally-neutral change.
---
 src/actions/profile-view.ts               | 2 +-
 src/components/calltree/CallTree.tsx      | 3 ++-
 src/components/flame-graph/FlameGraph.tsx | 2 +-
 src/components/stack-chart/index.tsx      | 2 +-
 4 files changed, 5 insertions(+), 4 deletions(-)

diff --git a/src/actions/profile-view.ts b/src/actions/profile-view.ts
index 51ff3dcdb4..6c9484cb05 100644
--- a/src/actions/profile-view.ts
+++ b/src/actions/profile-view.ts
@@ -2015,6 +2015,7 @@ export function toggleBottomBoxFullscreen(): ThunkAction<void> {
 export function handleCallNodeTransformShortcut(
   event: React.KeyboardEvent<HTMLElement>,
   threadsKey: ThreadsKey,
+  callNodeInfo: CallNodeInfo,
   callNodeIndex: IndexIntoCallNodeTable
 ): ThunkAction<void> {
   return (dispatch, getState) => {
@@ -2023,7 +2024,6 @@ export function handleCallNodeTransformShortcut(
     }
     const threadSelectors = getThreadSelectorsFromThreadsKey(threadsKey);
     const unfilteredThread = threadSelectors.getThread(getState());
-    const callNodeInfo = threadSelectors.getCallNodeInfo(getState());
     const implementation = getImplementationFilter(getState());
     const inverted = getInvertCallstack(getState());
     const callNodePath = callNodeInfo.getCallNodePathFromIndex(callNodeIndex);
diff --git a/src/components/calltree/CallTree.tsx b/src/components/calltree/CallTree.tsx
index 401247eee5..92355b2f63 100644
--- a/src/components/calltree/CallTree.tsx
+++ b/src/components/calltree/CallTree.tsx
@@ -276,6 +276,7 @@ class CallTreeImpl extends PureComponent<Props> {
       rightClickedCallNodeIndex,
       handleCallNodeTransformShortcut,
       threadsKey,
+      callNodeInfo,
     } = this.props;
     const nodeIndex =
       rightClickedCallNodeIndex !== null
@@ -284,7 +285,7 @@ class CallTreeImpl extends PureComponent<Props> {
     if (nodeIndex === null) {
       return;
     }
-    handleCallNodeTransformShortcut(event, threadsKey, nodeIndex);
+    handleCallNodeTransformShortcut(event, threadsKey, callNodeInfo, nodeIndex);
   };
 
   _onEnterOrDoubleClick = (nodeId: IndexIntoCallNodeTable) => {
diff --git a/src/components/flame-graph/FlameGraph.tsx b/src/components/flame-graph/FlameGraph.tsx
index 376d0f3025..b0c2ad5953 100644
--- a/src/components/flame-graph/FlameGraph.tsx
+++ b/src/components/flame-graph/FlameGraph.tsx
@@ -302,7 +302,7 @@ class FlameGraphImpl
       return;
     }
 
-    handleCallNodeTransformShortcut(event, threadsKey, nodeIndex);
+    handleCallNodeTransformShortcut(event, threadsKey, callNodeInfo, nodeIndex);
   };
 
   _onCopy = (event: ClipboardEvent) => {
diff --git a/src/components/stack-chart/index.tsx b/src/components/stack-chart/index.tsx
index ea20211a15..eeb1347034 100644
--- a/src/components/stack-chart/index.tsx
+++ b/src/components/stack-chart/index.tsx
@@ -179,7 +179,7 @@ class StackChartImpl extends React.PureComponent<Props> {
       return;
     }
 
-    handleCallNodeTransformShortcut(event, threadsKey, nodeIndex);
+    handleCallNodeTransformShortcut(event, threadsKey, callNodeInfo, nodeIndex);
   };
 
   _onDoubleClick = (callNodeIndex: IndexIntoCallNodeTable | null) => {