Merge commit from fork

Author: mcollina

deps/streamsearch/sbmh.js

@@ -53,7 +53,7 @@ function SBMH (needle) {
   this.maxMatches = Infinity
   this.matches = 0
 
-  this._occ = new Uint8Array(256)
+  this._occ = new Uint16Array(256)
     .fill(needleLength) // Initialize occurrence table.
   this._lookbehind_size = 0
   this._needle = needle

test/multipart-constructor.test.js

@@ -1,16 +1,38 @@
 'use strict'
 
+const { spawnSync } = require('node:child_process')
+const { test } = require('node:test')
 const Multipart = require('../lib/types/multipart')
 const Busboy = require('..')
-const { test } = require('node:test')
 
-test('multipart constructor', t => {
-  t.plan(1)
+test('multipart constructor', async t => {
+  t.plan(2)
 
-  t.test('throws if the boundary is not a string', t => {
+  await t.test('throws if the boundary is not a string', t => {
     const busboy = new Busboy({ headers: { 'content-type': 'application/x-www-form-urlencoded' } })
 
     t.assert.throws(() => new Multipart(busboy, { boundary: 123 }), { message: 'Multipart: Boundary not found' })
     t.assert.ok('end')
   })
+
+  await t.test('processes a fragmented 252-byte boundary without hanging', t => {
+    t.plan(1)
+
+    const script = `
+      const Busboy = require(${JSON.stringify(require.resolve('..'))})
+      const boundary = 'A'.repeat(252)
+      const parser = Busboy({
+        headers: { 'content-type': 'multipart/form-data; boundary=' + boundary }
+      })
+      parser.write(Buffer.from('--' + boundary.slice(0, -1)))
+      parser.write(Buffer.from('X'), (error) => process.exit(error ? 1 : 0))
+      setTimeout(() => process.exit(1), 500)
+    `
+    const result = spawnSync(process.execPath, ['-e', script], { timeout: 2000 })
+
+    t.assert.deepStrictEqual(
+      { error: result.error && result.error.code, signal: result.signal, status: result.status },
+      { error: undefined, signal: null, status: 0 }
+    )
+  })
 })

test/streamsearch.test.js

@@ -4,7 +4,7 @@ const { test } = require('node:test')
 const Streamsearch = require('../deps/streamsearch/sbmh')
 
 test('streamsearch', async t => {
-  t.plan(19)
+  t.plan(20)
 
   await t.test('should throw an error if the needle is not a String or Buffer', t => {
     t.plan(1)
@@ -27,6 +27,14 @@ test('streamsearch', async t => {
     t.assert.throws(() => new Streamsearch(Buffer.from(Array(257).fill('a').join(''))), { message: 'The needle cannot have a length bigger than 256.' })
   })
 
+  await t.test('should represent the maximum skip distance', t => {
+    t.plan(1)
+
+    const search = new Streamsearch(Buffer.alloc(256, 0x41))
+
+    t.assert.strictEqual(search._occ[0x42], 256)
+  })
+
   await t.test('should process a Buffer without a needle', t => {
     t.plan(5)
     const expected = [