Skip to content

Commit 9371e20

Browse files
chrfalchfacebook-github-bot
authored andcommitted
fixed build type when downloading hermes artifacts (#51283)
Summary: Hermes build-type was hardcoded to 'release' in the previous version of the prebuild scripts. This commit fixes this so that we can provide a build-type for hermes when downloading prebuilt tarballs. - Cleaned up parameters in hermes.js - Updated with buildType parameter when suitable - Fixed some function names - Updated version file so that it contains build type - Removed version file when using a local tarball ## Changelog: [IOS] [FIXED] - Fixed resolving build type when downloading hermes artifacts Pull Request resolved: #51283 Test Plan: No test-plan yet Reviewed By: cortinico Differential Revision: D74882001 Pulled By: cipolleschi fbshipit-source-id: cfeed934023712e70f7d04c137e8611164120cec
1 parent e2f6ce4 commit 9371e20

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

packages/react-native/scripts/ios-prebuild.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -109,7 +109,7 @@ async function main() {
109109
};
110110

111111
// HERMES ARTIFACTS
112-
await prepareHermesArtifactsAsync(currentVersion, 'release');
112+
await prepareHermesArtifactsAsync(currentVersion, 'debug');
113113

114114
// CODEGEN
115115
const codegenPath = path.join(root, '.build/codegen');

0 commit comments

Comments
 (0)