Skip to content

Commit 0d1cde7

Browse files
mdvaccafacebook-github-bot
authored andcommitted
Raise logLevel of LegacyArchitecture classes when minimizing of legacy architecture is enabled (#51876)
Summary: Pull Request resolved: #51876 This diff raises the logLevel of LegacyArchitecture classes when minimizing of legacy architecture is enabled Reviewed By: cortinico Differential Revision: D76080324 fbshipit-source-id: 3764c0657b912db81e0dc46b6eb57cbb02b335ba
1 parent 6da3b18 commit 0d1cde7

62 files changed

Lines changed: 95 additions & 62 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

packages/react-native/ReactAndroid/src/main/java/com/facebook/react/CoreModulesPackage.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,7 @@ import com.facebook.systrace.Systrace
5454
SourceCodeModule::class,
5555
TimingModule::class,
5656
UIManagerModule::class])
57-
@LegacyArchitecture
57+
@LegacyArchitecture(logLevel = LegacyArchitectureLogLevel.ERROR)
5858
internal class CoreModulesPackage(
5959
private val reactInstanceManager: ReactInstanceManager,
6060
private val hardwareBackBtnHandler: DefaultHardwareBackBtnHandler,

packages/react-native/ReactAndroid/src/main/java/com/facebook/react/JSEngineResolutionAlgorithm.kt

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,13 +8,14 @@
88
package com.facebook.react
99

1010
import com.facebook.react.common.annotations.internal.LegacyArchitecture
11+
import com.facebook.react.common.annotations.internal.LegacyArchitectureLogLevel
1112

1213
/**
1314
* An enum that specifies the algorithm to use when loading theJS Engine. [.JSC] will load
1415
* JavaScriptCore first and fail if it is not available. [.HERMES] will load Hermes first and fail
1516
* if it is not available.
1617
*/
17-
@LegacyArchitecture
18+
@LegacyArchitecture(logLevel = LegacyArchitectureLogLevel.ERROR)
1819
public enum class JSEngineResolutionAlgorithm {
1920
JSC,
2021
HERMES

packages/react-native/ReactAndroid/src/main/java/com/facebook/react/LazyReactPackage.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ import com.facebook.systrace.SystraceMessage
2424

2525
/** React package supporting lazy creation of native modules. */
2626
@Deprecated("This class is deprecated, please use BaseReactPackage instead.")
27-
@LegacyArchitecture
27+
@LegacyArchitecture(logLevel = LegacyArchitectureLogLevel.ERROR)
2828
public abstract class LazyReactPackage : ReactPackage {
2929
/**
3030
* We return an iterable

packages/react-native/ReactAndroid/src/main/java/com/facebook/react/NativeModuleRegistryBuilder.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ import com.facebook.react.common.annotations.internal.LegacyArchitectureLogLevel
1515
import com.facebook.react.common.annotations.internal.LegacyArchitectureLogger
1616

1717
/** Helper class to build NativeModuleRegistry. */
18-
@LegacyArchitecture
18+
@LegacyArchitecture(logLevel = LegacyArchitectureLogLevel.ERROR)
1919
public class NativeModuleRegistryBuilder(
2020
private val reactApplicationContext: ReactApplicationContext,
2121
) {

packages/react-native/ReactAndroid/src/main/java/com/facebook/react/ReactInstanceManagerBuilder.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@
4545
import java.util.Map;
4646

4747
/** Builder class for {@link ReactInstanceManager} */
48-
@LegacyArchitecture
48+
@LegacyArchitecture(logLevel = LegacyArchitectureLogLevel.ERROR)
4949
public class ReactInstanceManagerBuilder {
5050

5151
static {

packages/react-native/ReactAndroid/src/main/java/com/facebook/react/ReactNativeHost.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@
3737
message =
3838
"This class will be replaced by com.facebook.react.ReactHost in the new architecture of"
3939
+ " React Native.")
40-
@LegacyArchitecture
40+
@LegacyArchitecture(logLevel = LegacyArchitectureLogLevel.ERROR)
4141
public abstract class ReactNativeHost {
4242

4343
static {

packages/react-native/ReactAndroid/src/main/java/com/facebook/react/ReactPackageLogger.kt

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,9 +8,10 @@
88
package com.facebook.react
99

1010
import com.facebook.react.common.annotations.internal.LegacyArchitecture
11+
import com.facebook.react.common.annotations.internal.LegacyArchitectureLogLevel
1112

1213
/** Interface for the bridge to call for TTI start and end markers. */
13-
@LegacyArchitecture
14+
@LegacyArchitecture(logLevel = LegacyArchitectureLogLevel.ERROR)
1415
internal interface ReactPackageLogger {
1516
fun startProcessPackage(): Unit
1617

packages/react-native/ReactAndroid/src/main/java/com/facebook/react/bridge/BridgeReactContext.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@
3636
*/
3737
@DeprecatedInNewArchitecture
3838
@VisibleForTesting
39-
@LegacyArchitecture
39+
@LegacyArchitecture(logLevel = LegacyArchitectureLogLevel.ERROR)
4040
public class BridgeReactContext extends ReactApplicationContext {
4141
static {
4242
LegacyArchitectureLogger.assertLegacyArchitecture(

packages/react-native/ReactAndroid/src/main/java/com/facebook/react/bridge/CallbackImpl.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ import com.facebook.react.common.annotations.internal.LegacyArchitectureLogLevel
1212
import com.facebook.react.common.annotations.internal.LegacyArchitectureLogger
1313

1414
/** Implementation of javascript callback function that uses Bridge to schedule method execution. */
15-
@LegacyArchitecture
15+
@LegacyArchitecture(logLevel = LegacyArchitectureLogLevel.ERROR)
1616
internal class CallbackImpl(private val jsInstance: JSInstance, private val callbackId: Int) :
1717
Callback {
1818
private var invoked = false

packages/react-native/ReactAndroid/src/main/java/com/facebook/react/bridge/JSONArguments.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ import org.json.JSONArray
1414
import org.json.JSONException
1515
import org.json.JSONObject
1616

17-
@LegacyArchitecture
17+
@LegacyArchitecture(logLevel = LegacyArchitectureLogLevel.ERROR)
1818
public object JSONArguments {
1919

2020
init {

0 commit comments

Comments
 (0)