review comments resolved

Author: alirana01

bundles/com.espressif.idf.core/src/com/espressif/idf/core/build/messages.properties

@@ -31,11 +31,11 @@ IDFToolChainsMissingErrorMsg=Toolchains are missing. Please use ESP-IDF Manager
 NoActiveEspIdfInWorkspaceMsgTitle=ESP-IDF Setup
 NoActiveEspIdfInWorkspaceMsg=ESP-IDF is required to use Espressif IDE. Would you like to configure it now?
 
-OldConfigFoundMsgBoxTitle=Old Configuration Found
-OldConfigFoundMsgBoxMsg=Please export the current workspace configuration to the EIM configuration for proper environment setup. Do you want to export configurations?
+OldConfigFoundMsgBoxTitle=Old Configuration Detected
+OldConfigFoundMsgBoxMsg=Espressif IDE now uses the EIM system to manage ESP-IDF installations. A legacy configuration was found in your current workspace. Converting it to the EIM format will allow proper environment setup and ensure the IDE works seamlessly with your existing projects. Would you like to convert the configuration now?
 OldConfigExportDirectorSelectionDialogTitle=Select Destination
 OldConfigExportDirectorSelectionDialogInfo=Choose a directory to save the exported settings.
 OldConfigExportCompleteSuccessMsgTitle=Import Successful
 OldConfigExportCompleteSuccessMsg=The configuration has been successfully Imported
-OldConfigExportCompleteFailMsgTitle=Import Failed
-OldConfigExportCompleteFailMsg=An error occurred while importing old configuration.
+OldConfigExportCompleteFailMsgTitle=Conversion Failed
+OldConfigExportCompleteFailMsg=An error occurred while converting old configuration.

bundles/com.espressif.idf.core/src/com/espressif/idf/core/logging/Logger.java

@@ -20,6 +20,10 @@
  */
 public class Logger
 {
+	public static void log(String message, Exception e)
+	{
+		log(IDFCorePlugin.getPlugin(), message, e);
+	}
 
 	public static void log(String message)
 	{

bundles/com.espressif.idf.ui/src/com/espressif/idf/ui/tools/EspressifToolStartup.java

@@ -52,18 +52,19 @@ public void earlyStartup()
 		preferences = org.eclipse.core.runtime.preferences.InstanceScope.INSTANCE.getNode(UIPlugin.PLUGIN_ID);
 		toolInitializer = new ToolInitializer(preferences);
 
-		if (toolInitializer.isEspIdfSet() && toolInitializer.isOldEspIdfConfigPresent()
-				&& !toolInitializer.isOldConfigExported())
-		{
-			Logger.log("Old configuration not imported");
-			handleOldConfigExport();
-		}
-
 		if (!toolInitializer.isEimInstalled())
 		{
+			Logger.log("EIM not installed");
 			notifyMissingTools();
 			return;
 		}
+		
+		if (toolInitializer.isOldEspIdfConfigPresent()
+				&& !toolInitializer.isOldConfigExported())
+		{
+			Logger.log("Old configuration found and not converted");
+			handleOldConfigExport();
+		}
 
 		EimJson eimJson = toolInitializer.loadEimJson();
 		if (eimJson == null)
@@ -119,8 +120,7 @@ private void handleOldConfigExport()
 			}
 			catch (IOException e)
 			{
-				Logger.log("Error exporting old configuration");
-				Logger.log(e);
+				Logger.log("Error exporting old configuration", e);
 				displayInformationMessageBox(Messages.OldConfigExportCompleteFailMsgTitle,
 						Messages.OldConfigExportCompleteFailMsg);
 			}