docs: update outdated http links to https in docs/rules - #562
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request?
Fix outdated/dead
http://links indocs/rulesand update them tohttps://, using each link's actual current destination instead of just swapping the protocol.What changes did you make? (Give an overview)
docs/rules/no-unsupported-features/es-builtins.md,es-syntax.md,node-builtins.md: the "shared settings" link pointed tohttp://eslint.org/docs/user-guide/configuring.html#adding-shared-settings, which now 404s after eslint.org's docs restructure. Updated to the current page:https://eslint.org/docs/latest/use/configure/configuration-files#configuring-shared-settings.docs/rules/process-exit-as-throw.md: theconsistent-return,no-fallthrough, andno-unreachablereference links used the old/docs/rules/...path, which now redirects to/docs/latest/rules/.... Updated to the final destination to avoid the unnecessary redirect.I verified each link with
curl -Lbefore changing anything, and rannpm testlocally — all checks pass.Related Issues
N/A — no existing issue in this repository covers this; confirmed by searching both open and closed issues/PRs for "http", "https", and "link".
Is there anything you'd like reviewers to focus on?
Note: left a few other
http://occurrences untouched (author link inno-sync.jsthat now redirects elsewhere, and a test fixture string inno-missing-import.js) since they aren't real links to fix.