fix(prefer-promises/fs): add missing fs.promises APIs (cp, glob, lutimes, opendir, rm, statfs) - #522
Merged
aladdin-add merged 1 commit intoMay 2, 2026
Conversation
…mes, opendir, rm, statfs)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
prefer-promises/fsrule'straceMaponly covers a subset offscallback-style methods, missing several that have had promise equivalents in Node.js for years:fs.promisesavailable sincecpgloblutimesopendirrmstatfsUsing any of these callback-style while writing otherwise promise-based code goes silently undetected by the rule, defeating its purpose.
Fix
Add the six missing methods to
traceMap.fs(and, by extension,traceMap["node:fs"]which is aliased from it):Tests
Added an invalid-code test case for each of the six new methods, verifying that the rule reports
preferPromisesforfs.cp(),fs.glob(),fs.lutimes(),fs.opendir(),fs.rm(), andfs.statfs().