Skip to content

Manually update Microsoft.Private.Intellisense to 8.0.0-preview-20230828.1#774

Merged
mthalman merged 3 commits into
dotnet:mainfrom
carlossanlop:BumpMicrosoftPrivateIntellisense
Sep 1, 2023
Merged

Manually update Microsoft.Private.Intellisense to 8.0.0-preview-20230828.1#774
mthalman merged 3 commits into
dotnet:mainfrom
carlossanlop:BumpMicrosoftPrivateIntellisense

Conversation

@carlossanlop

@carlossanlop carlossanlop commented Sep 1, 2023

Copy link
Copy Markdown
Contributor

As suggested in this comment: dotnet/runtime#91285 (comment) I ran:

generate.cmd/sh -p Microsoft.Private.Intellisense,8.0.0-preview-20230828.1 -t text

This is the workaround for dotnet/runtime#77004

@ViktorHofer @mthalman @MichaelSimons please review to unblock dotnet/runtime#91285

@mthalman mthalman left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since runtime is the only repo referencing this package that participates in source-build, the old version can be deleted.

Also, as stated in the workflow, the new project should be added to Build.props.

@ViktorHofer

Copy link
Copy Markdown
Member

It's not just runtime. At least winforms uses that package as well. But they should also upgrade to the new version as part of this. Therefore deleting the old version makes sense.

@ViktorHofer ViktorHofer left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider deleting the old version

@carlossanlop

Copy link
Copy Markdown
Contributor Author

@mthalman @ViktorHofer can I delete the old version in a separate PR? I first need to ensure that the other repos that consume the package have already upgraded to 20230828.1, otherwise we would end up with the same problem we're trying to fix, I am assuming.

@carlossanlop

Copy link
Copy Markdown
Contributor Author

I created dotnet/source-build#3611 to track the deletion request and assigned it to myself, so that we can unblock this PR. @mthalman would you mind merging this?

@mthalman

mthalman commented Sep 1, 2023

Copy link
Copy Markdown
Member

I created dotnet/source-build#3611 to track the deletion request and assigned it to myself, so that we can unblock this PR. @mthalman would you mind merging this?

Even without deleting the old version, this can't be merged until Build.props file is updated.

@carlossanlop

Copy link
Copy Markdown
Contributor Author

Package 7.0.0-preview-20221010.1 is consumed by .NET 7.0. Would it cause source-build problems in that .NET version if I delete that folder?

@mthalman

mthalman commented Sep 1, 2023

Copy link
Copy Markdown
Member

Package 7.0.0-preview-20221010.1 is consumed by .NET 7.0. Would it cause source-build problems in that .NET version if I delete that folder?

No. SBRP is only used for .NET 8+.

@carlossanlop

Copy link
Copy Markdown
Contributor Author

Ok thanks for confirming. I deleted the old code and also added the missing item in Build.props.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants