From 2024eedd494013e28ab339a09cc754f9712fbc12 Mon Sep 17 00:00:00 2001 From: Kevin Jones Date: Thu, 19 Sep 2024 12:07:11 -0400 Subject: [PATCH 1/3] Extend remote execution timeout --- .../X509Certificates/PfxIterationCountTests.X509Certificate2.cs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/libraries/System.Security.Cryptography/tests/X509Certificates/PfxIterationCountTests.X509Certificate2.cs b/src/libraries/System.Security.Cryptography/tests/X509Certificates/PfxIterationCountTests.X509Certificate2.cs index ce5c3be483da75..08d24375203f1b 100644 --- a/src/libraries/System.Security.Cryptography/tests/X509Certificates/PfxIterationCountTests.X509Certificate2.cs +++ b/src/libraries/System.Security.Cryptography/tests/X509Certificates/PfxIterationCountTests.X509Certificate2.cs @@ -32,7 +32,7 @@ internal override X509Certificate Import(string fileName, SecureString password) [ConditionalFact(typeof(RemoteExecutor), nameof(RemoteExecutor.IsSupported))] public static void Import_IterationCountLimitExceeded_ThrowsInAllottedTime() { - const int AllottedTime = 5000; + const int AllottedTime = 10_000; if (!PfxTests.Pkcs12PBES2Supported) { From f7bd80eb2b2aaba6a7c2d4f5db0081a370924aae Mon Sep 17 00:00:00 2001 From: Kevin Jones Date: Thu, 19 Sep 2024 12:50:08 -0400 Subject: [PATCH 2/3] Also move to Outerloop --- .../X509Certificates/PfxIterationCountTests.X509Certificate2.cs | 1 + 1 file changed, 1 insertion(+) diff --git a/src/libraries/System.Security.Cryptography/tests/X509Certificates/PfxIterationCountTests.X509Certificate2.cs b/src/libraries/System.Security.Cryptography/tests/X509Certificates/PfxIterationCountTests.X509Certificate2.cs index 08d24375203f1b..f1ee3c93fcb1ab 100644 --- a/src/libraries/System.Security.Cryptography/tests/X509Certificates/PfxIterationCountTests.X509Certificate2.cs +++ b/src/libraries/System.Security.Cryptography/tests/X509Certificates/PfxIterationCountTests.X509Certificate2.cs @@ -30,6 +30,7 @@ internal override X509Certificate Import(string fileName, SecureString password) [ConditionalFact(typeof(RemoteExecutor), nameof(RemoteExecutor.IsSupported))] + [Outerloop("Sensitive to timeouts and may fail in very busy environments.")] public static void Import_IterationCountLimitExceeded_ThrowsInAllottedTime() { const int AllottedTime = 10_000; From ef656d7b77b3fad102b26d6805f268ab622ce6c6 Mon Sep 17 00:00:00 2001 From: Kevin Jones Date: Thu, 19 Sep 2024 13:34:06 -0400 Subject: [PATCH 3/3] L --- .../X509Certificates/PfxIterationCountTests.X509Certificate2.cs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/libraries/System.Security.Cryptography/tests/X509Certificates/PfxIterationCountTests.X509Certificate2.cs b/src/libraries/System.Security.Cryptography/tests/X509Certificates/PfxIterationCountTests.X509Certificate2.cs index f1ee3c93fcb1ab..e997796b4c99cd 100644 --- a/src/libraries/System.Security.Cryptography/tests/X509Certificates/PfxIterationCountTests.X509Certificate2.cs +++ b/src/libraries/System.Security.Cryptography/tests/X509Certificates/PfxIterationCountTests.X509Certificate2.cs @@ -30,7 +30,7 @@ internal override X509Certificate Import(string fileName, SecureString password) [ConditionalFact(typeof(RemoteExecutor), nameof(RemoteExecutor.IsSupported))] - [Outerloop("Sensitive to timeouts and may fail in very busy environments.")] + [OuterLoop("Sensitive to timeouts and may fail in very busy environments.")] public static void Import_IterationCountLimitExceeded_ThrowsInAllottedTime() { const int AllottedTime = 10_000;