Enable IDE0060 (Remove unused parameter) analyzer

Author: marek-safar

eng/CodeAnalysis.src.globalconfig

@@ -1463,7 +1463,7 @@ dotnet_diagnostic.IDE0058.severity = silent
 dotnet_diagnostic.IDE0059.severity = warning
 
 # IDE0060: Remove unused parameter
-dotnet_diagnostic.IDE0060.severity = silent
+dotnet_diagnostic.IDE0060.severity = warning
 dotnet_code_quality_unused_parameters = non_public
 
 # IDE0061: Use expression body for local functions

src/coreclr/System.Private.CoreLib/src/System/Runtime/InteropServices/Marshal.CoreCLR.cs

@@ -300,9 +300,10 @@ public static string GetTypeInfoName(ITypeInfo typeInfo!!)
             return strTypeLibName;
         }
 
+#pragma warning disable IDE0060
         // This method is identical to Type.GetTypeFromCLSID. Since it's interop specific, we expose it
         // on Marshal for more consistent API surface.
-        internal static Type? GetTypeFromCLSID(Guid clsid, string? server, bool throwOnError)
+        internal static Type? GetTypeFromCLSID(Guid clsid, string? server, bool *throwOnError)
         {
             if (!IsBuiltInComSupported)
             {
@@ -316,6 +317,7 @@ public static string GetTypeInfoName(ITypeInfo typeInfo!!)
             GetTypeFromCLSID(clsid, server, ObjectHandleOnStack.Create(ref type));
             return type;
         }
+#pragma warning restore IDE0060
 
         [LibraryImport(RuntimeHelpers.QCall, EntryPoint = "MarshalNative_GetTypeFromCLSID", StringMarshalling = StringMarshalling.Utf16)]
         private static partial void GetTypeFromCLSID(in Guid clsid, string? server, ObjectHandleOnStack retType);

src/coreclr/nativeaot/Common/src/System/Collections/Concurrent/ConcurrentUnifierWKeyed.cs

@@ -161,7 +161,7 @@ public V GetOrAdd(K key)
                     return heyIWasHereFirst;
                 if (!_container.HasCapacity)
                     _container.Resize(); // This overwrites the _container field.
-                _container.Add(key, hashCode, value);
+                _container.Add(hashCode, value);
                 return value;
             }
         }
@@ -218,7 +218,7 @@ public bool TryGetValue(K key, int hashCode, out V value)
                 return false;
             }
 
-            public void Add(K key, int hashCode, V value)
+            public void Add(int hashCode, V value)
             {
                 Debug.Assert(_owner._lock.IsAcquired);
 

src/coreclr/nativeaot/Runtime.Base/src/System/AttributeUsageAttribute.cs

@@ -16,6 +16,7 @@ namespace System
     [AttributeUsage(AttributeTargets.Class, Inherited = true)]
     internal sealed class AttributeUsageAttribute : Attribute
     {
+#pragma warning disable IDE0060
         //Constructors
         public AttributeUsageAttribute(AttributeTargets validOn)
         {
@@ -24,6 +25,7 @@ public AttributeUsageAttribute(AttributeTargets validOn)
         public AttributeUsageAttribute(AttributeTargets validOn, bool allowMultiple, bool inherited)
         {
         }
+#pragma warning restore IDE0060
 
         //Properties.
         // Allowing the set properties as it allows a more readable syntax in the specifiers (and are commonly used)

src/coreclr/nativeaot/Runtime.Base/src/System/Runtime/ExceptionHandling.cs

@@ -76,7 +76,7 @@ private struct EHEnum
 
         // This is a fail-fast function used by the runtime as a last resort that will terminate the process with
         // as little effort as possible. No guarantee is made about the semantics of this fail-fast.
-        internal static void FallbackFailFast(RhFailFastReason reason, object unhandledException)
+        internal static void FallbackFailFast(RhFailFastReason _ /*reason*/, object _1 /*unhandledException*/)
         {
             InternalCalls.RhpFallbackFailFast();
         }
@@ -923,6 +923,7 @@ private static void InvokeSecondPass(ref ExInfo exInfo, uint idxStart, uint idxL
             }
         }
 
+#pragma warning disable IDE0060
         [UnmanagedCallersOnly(EntryPoint = "RhpFailFastForPInvokeExceptionPreemp", CallConvs = new Type[] { typeof(CallConvCdecl) })]
         public static void RhpFailFastForPInvokeExceptionPreemp(IntPtr PInvokeCallsiteReturnAddr, void* pExceptionRecord, void* pContextRecord)
         {
@@ -933,5 +934,7 @@ public static void RhpFailFastForPInvokeExceptionCoop(IntPtr classlibBreadcrumb,
         {
             FailFastViaClasslib(RhFailFastReason.PN_UnhandledExceptionFromPInvoke, null, classlibBreadcrumb);
         }
+#pragma warning restore IDE0060
+
     } // static class EH
 }

src/coreclr/nativeaot/System.Private.CoreLib/src/System/Delegate.cs

@@ -231,7 +231,7 @@ private void InitializeClosedStaticThunk(object firstParameter, IntPtr functionP
         }
 
         // This function is known to the compiler backend.
-        private void InitializeOpenStaticThunk(object firstParameter, IntPtr functionPointer, IntPtr functionPointerThunk)
+        private void InitializeOpenStaticThunk(object _ /*firstParameter*/, IntPtr functionPointer, IntPtr functionPointerThunk)
         {
             // This sort of delegate is invoked by calling the thunk function pointer with the arguments to the delegate + a reference to the delegate object itself.
             m_firstParameter = this;
@@ -483,10 +483,12 @@ private string GetTargetMethodsDescriptionForDebugger()
             }
         }
 
+#pragma warning disable IDE0060
         private static string DebuggerFunctionPointerFormattingHook(IntPtr functionPointer, RuntimeTypeHandle typeOfFirstParameterIfInstanceDelegate)
         {
             // This method will be hooked by the debugger and the debugger will cause it to return a description for the function pointer
             throw new NotSupportedException();
         }
+#pragma warning restore IDE0060
     }
 }

src/coreclr/nativeaot/System.Private.CoreLib/src/System/Enum.CoreRT.cs

@@ -16,7 +16,7 @@ namespace System
 {
     public abstract partial class Enum : ValueType, IComparable, IFormattable, IConvertible
     {
-        internal static EnumInfo GetEnumInfo(Type enumType, bool getNames = true)
+        internal static EnumInfo GetEnumInfo(Type enumType, bool _ /*getNames*/ = true)
         {
             Debug.Assert(enumType != null);
             Debug.Assert(enumType is RuntimeType);

src/coreclr/nativeaot/System.Private.CoreLib/src/System/Environment.CoreRT.cs

@@ -43,7 +43,7 @@ public static void FailFast(string message) =>
         public static void FailFast(string message, Exception exception) =>
             RuntimeExceptionHelpers.FailFast(message, exception);
 
-        internal static void FailFast(string message, Exception exception, string errorSource)
+        internal static void FailFast(string message, Exception exception, string _ /*errorSource*/)
         {
             // TODO: errorSource originates from CoreCLR (See: https://github.com/dotnet/coreclr/pull/15895)
             // For now, we ignore errorSource on CoreRT but we should distinguish the way FailFast prints exception message using errorSource

src/coreclr/nativeaot/System.Private.CoreLib/src/System/IO/FileLoadException.CoreRT.cs

@@ -5,7 +5,7 @@ namespace System.IO
 {
     public partial class FileLoadException
     {
-        internal static string FormatFileLoadExceptionMessage(string? fileName, int hResult)
+        internal static string FormatFileLoadExceptionMessage(string? fileName, int _ /*hResult*/)
         {
             return fileName == null ? SR.IO_FileLoad : SR.Format(SR.IO_FileLoad_FileName, fileName);
         }

src/coreclr/nativeaot/System.Private.CoreLib/src/System/InvokeUtils.cs

@@ -273,7 +273,7 @@ private static Exception CreateChangeTypeException(EETypePtr srcEEType, EETypePt
                 case CheckArgumentSemantics.SetFieldDirect:
                     return CreateChangeTypeArgumentException(srcEEType, dstEEType);
                 case CheckArgumentSemantics.ArraySet:
-                    return CreateChangeTypeInvalidCastException(srcEEType, dstEEType);
+                    return CreateChangeTypeInvalidCastException();
                 default:
                     Debug.Fail("Unexpected CheckArgumentSemantics value: " + semantics);
                     throw new InvalidOperationException();
@@ -285,7 +285,7 @@ private static ArgumentException CreateChangeTypeArgumentException(EETypePtr src
             return new ArgumentException(SR.Format(SR.Arg_ObjObjEx, Type.GetTypeFromHandle(new RuntimeTypeHandle(srcEEType)), Type.GetTypeFromHandle(new RuntimeTypeHandle(dstEEType))));
         }
 
-        private static InvalidCastException CreateChangeTypeInvalidCastException(EETypePtr srcEEType, EETypePtr dstEEType)
+        private static InvalidCastException CreateChangeTypeInvalidCastException()
         {
             return new InvalidCastException(SR.InvalidCast_StoreArrayElement);
         }
@@ -548,7 +548,7 @@ internal static object DynamicInvokeBoxedValuetypeReturn(out DynamicInvokeParamL
             return finalObjectToReturn;
         }
 
-        internal static object DynamicInvokeUnmanagedPointerReturn(out DynamicInvokeParamLookupType paramLookupType, object? boxedPointerType, int index, RuntimeTypeHandle type, DynamicInvokeParamType paramType)
+        internal static object DynamicInvokeUnmanagedPointerReturn(out DynamicInvokeParamLookupType paramLookupType, object? boxedPointerType)
         {
             object finalObjectToReturn = boxedPointerType;
 
@@ -630,7 +630,7 @@ public static object DynamicInvokeParamHelperCore(ref ArgSetupState argSetupStat
             else if (type.ToEETypePtr().IsPointer)
             {
                 incomingParam = InvokeUtils.CheckArgument(incomingParam, type.ToEETypePtr(), InvokeUtils.CheckArgumentSemantics.DynamicInvoke, argSetupState.binderBundle, ref argSetupState);
-                return DynamicInvokeUnmanagedPointerReturn(out paramLookupType, incomingParam, index, type, paramType);
+                return DynamicInvokeUnmanagedPointerReturn(out paramLookupType, incomingParam);
             }
             else
             {