Skip to content

Commit 4378e2a

Browse files
Allow null SdkResult from SdkResolver.Resolve (#13197)
The doc comment explicitly mentions returning null and the SDK can do so, which caused a break in dotnet/dotnet#4579: src\sdk\src\Resolvers\Microsoft.NET.Sdk.WorkloadMSBuildSdkResolver\WorkloadSdkResolver.cs(35,36): error CS8764: Nullability of return type doesn't match overridden member (possibly because of nullability attributes). Follow up to #13157 / 0172c58.
1 parent 7e0e757 commit 4378e2a

1 file changed

Lines changed: 3 additions & 4 deletions

File tree

src/Framework/Sdk/SdkResolver.cs

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -31,10 +31,9 @@ public abstract class SdkResolver
3131
/// applicable for a particular <see cref="SdkReference"/>.
3232
/// </returns>
3333
/// <remarks>
34-
/// Note: You must use <see cref="SdkResultFactory"/> to return a result.
35-
/// </remarks>
36-
///
37-
public abstract SdkResult Resolve(SdkReference sdkReference,
34+
/// Note: You must use <see cref="SdkResultFactory"/> to return a result.
35+
/// </remarks>
36+
public abstract SdkResult? Resolve(SdkReference sdkReference,
3837
SdkResolverContext resolverContext,
3938
SdkResultFactory factory);
4039
}

0 commit comments

Comments
 (0)