VSCode: Package bricks from GH actions - #83
Merged
Merged
Conversation
fjakobs
force-pushed
the
package-windows
branch
6 times, most recently
from
September 9, 2022 10:20
1e09807 to
4641495
Compare
fjakobs
force-pushed
the
package-windows
branch
3 times, most recently
from
September 9, 2022 11:45
6c822b1 to
da80b9b
Compare
fjakobs
force-pushed
the
package-windows
branch
from
September 9, 2022 11:50
da80b9b to
e374d27
Compare
| it("should embed a working bricks CLI", async () => { | ||
| let bricksPath = __dirname + "/../../bin/bricks"; | ||
| let result = await execFile(bricksPath, ["--help"]); | ||
| assert.ok(result.stdout.indexOf("bricks") > 0); |
Contributor
There was a problem hiding this comment.
Asserting exit code might be better here since stdout could be populated by errors as well.
Contributor
Author
There was a problem hiding this comment.
I check that. For a non 0 exit code the execFile command will actually throw an exception and thus fail the test.
| "vscode:prepublish": "rm -rf out && yarn run package:compile && yarn run package:copy-webview-toolkit", | ||
| "package": "vsce package", | ||
| "package:cli:fetch": "bash ./scripts/fetch-bricks-cli.sh v0.0.1 ${BRICKS_ARCH:-}", | ||
| "package:cli:fetch": "BRICKS_VERSION=v0.0.2 && bash ./scripts/fetch-bricks-cli.sh ${BRICKS_VERSION} ${BRICKS_ARCH:-}", |
Contributor
There was a problem hiding this comment.
Just wondering if it would it be good to have a fetch:latest as well?
Contributor
Author
There was a problem hiding this comment.
Absolutely. Let's track that in a separate ticket.
|
|
||
| - name: Build VSIX | ||
| run: yarn workspace databricks package -o artifacts | ||
| run: yarn workspace databricks package -o artifacts -t darwin-x64 |
Contributor
There was a problem hiding this comment.
Why target darwin? I believe if target is not specified it takes the architecture of the runtime machine? If not can we use matrix.vsix-arch?
Contributor
Author
There was a problem hiding this comment.
I just wanted to be explicit.
kartikgupta-db
approved these changes
Sep 9, 2022
This was referenced Nov 4, 2022
Closed
Closed
Closed
Closed
Closed
Closed
Merged
Closed
Merged
Merged
This was referenced Nov 10, 2022
Merged
Merged
Merged
Merged
This was referenced Nov 11, 2022
Closed
Closed
Merged
Merged
Closed
Closed
Closed
Closed
Merged
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.