Hide "create" quick pick items when filter is applied (#189)

- Hide "create" quick pick items when filter is applied
- Replace chai with sinon and fake timer for retry unit tests - teast
are running in a few ms new instead of in 8 seconds.

Author: fjakobs

packages/databricks-sdk-js/package.json

@@ -36,21 +36,17 @@
     },
     "devDependencies": {
         "@istanbuljs/nyc-config-typescript": "^1.0.2",
-        "@types/chai": "^4.3.3",
-        "@types/chai-as-promised": "^7.1.5",
-        "@types/chai-spies": "^1.0.3",
         "@types/ini": "^1.3.31",
         "@types/mocha": "^10.0.0",
         "@types/node": "^18.11.9",
+        "@types/sinon": "^10.0.13",
         "@types/tmp": "^0.2.3",
         "@types/uuid": "^8.3.4",
-        "chai": "^4.3.6",
-        "chai-as-promised": "^7.1.1",
-        "chai-spies": "^1.0.0",
         "eslint": "^8.26.0",
         "mocha": "^10.1.0",
         "nyc": "^15.1.0",
         "prettier": "^2.7.1",
+        "sinon": "^14.0.2",
         "tmp-promise": "^3.0.3",
         "ts-loader": "^9.4.1",
         "ts-mocha": "^10.0.0",

packages/databricks-sdk-js/src/retries/retries.test.ts

@@ -1,20 +1,26 @@
 import retry, {RetriableError, TimeoutError} from "./retries";
 import Time, {TimeUnits} from "./Time";
-import chai, {assert, expect} from "chai";
-import spies from "chai-spies";
-import chaiAsPromised from "chai-as-promised";
+import * as sinon from "sinon";
+import * as assert from "node:assert";
 
-chai.use(chaiAsPromised);
-chai.use(spies);
 class NonRetriableError extends Error {}
 
 describe(__filename, function () {
-    this.timeout(new Time(10, TimeUnits.minutes).toMillSeconds().value);
+    let fakeTimer: sinon.SinonFakeTimers;
 
+    beforeEach(() => {
+        fakeTimer = sinon.useFakeTimers();
+    });
+
+    afterEach(() => {
+        fakeTimer.restore();
+    });
+
+    this.timeout(1000 * 3);
     it("should return result if timeout doesn't expire", async function () {
         const startTime = Date.now();
 
-        const retryResult = await retry({
+        const retryResult = retry({
             timeout: new Time(5, TimeUnits.seconds),
             fn: () => {
                 if (Date.now() - startTime < 1000) {
@@ -26,39 +32,57 @@ describe(__filename, function () {
             },
         });
 
-        assert.equal(retryResult, "returned_string");
+        fakeTimer.tick(800);
+        fakeTimer.tick(800);
+        fakeTimer.tick(800);
+
+        assert.equal(await retryResult, "returned_string");
     });
 
     it("should return retriable error if timeout expires", async function () {
         const startTime = Date.now();
-        await expect(
-            retry({
-                timeout: new Time(5, TimeUnits.seconds),
-                fn: () => {
-                    if (Date.now() - startTime < 10000) {
-                        throw new RetriableError();
-                    }
-                    return new Promise<string>((resolve) =>
-                        resolve("returned_string")
-                    );
-                },
-            })
-        ).to.be.rejectedWith(TimeoutError);
+
+        const retryResult = retry({
+            timeout: new Time(5, TimeUnits.seconds),
+            fn: () => {
+                if (Date.now() - startTime < 10000) {
+                    throw new RetriableError();
+                }
+                return new Promise<string>((resolve) =>
+                    resolve("returned_string")
+                );
+            },
+        });
+
+        fakeTimer.tick(800);
+        fakeTimer.tick(800);
+        fakeTimer.tick(2000);
+        fakeTimer.tick(5000);
+
+        try {
+            await retryResult;
+            assert.fail("should throw TimeoutError");
+        } catch (err) {
+            assert.ok(err instanceof TimeoutError);
+        }
     });
 
     it("should throw non retriable error immediately", async function () {
-        const mockFunction = chai.spy();
+        let callCount = 0;
 
-        await expect(
-            retry({
+        try {
+            await retry({
                 timeout: new Time(5, TimeUnits.seconds),
                 fn: () => {
-                    mockFunction();
+                    callCount += 1;
                     throw new NonRetriableError();
                 },
-            })
-        ).to.be.rejectedWith(NonRetriableError);
+            });
+            assert.fail("should throw NonRetriableError");
+        } catch (err) {
+            assert.ok(err instanceof NonRetriableError);
+        }
 
-        expect(mockFunction).to.be.called.once;
+        assert.equal(callCount, 1);
     });
 });

packages/databricks-sdk-js/src/services/Cluster.integ.ts

@@ -1,13 +1,9 @@
 /* eslint-disable @typescript-eslint/naming-convention */
 
 import {Cluster} from "..";
-import assert from "assert";
-import chai from "chai";
-import chaiAsPromised from "chai-as-promised";
+import assert from "node:assert";
 import {IntegrationTestSetup} from "../test/IntegrationTestSetup";
 
-chai.use(chaiAsPromised);
-
 describe(__filename, function () {
     let integSetup: IntegrationTestSetup;
 

packages/databricks-sdk-js/src/services/Cluster.test.ts

@@ -1,17 +1,14 @@
 /* eslint-disable @typescript-eslint/naming-convention */
 
 import {ApiClient, Cluster} from "..";
-import chai, {assert} from "chai";
+import * as assert from "node:assert";
 import {mock, when, instance, deepEqual, verify, anything} from "ts-mockito";
-import chaiAsPromised from "chai-as-promised";
 import Time, {TimeUnits} from "../retries/Time";
 import {getMockTestCluster} from "../test/fixtures/ClusterFixtures";
 import {ClusterInfo} from "../apis/clusters";
 import {TokenFixture} from "../test/fixtures/TokenFixtures";
 import {RetryConfigs} from "../retries/retries";
 
-chai.use(chaiAsPromised);
-
 describe(__filename, function () {
     this.timeout(new Time(10, TimeUnits.minutes).toMillSeconds().value);
 

packages/databricks-vscode/src/configuration/ConnectionCommands.ts

@@ -111,7 +111,7 @@ export class ConnectionCommands implements Disposable {
                 {
                     label: "Create New Cluster",
                     detail: `Open Databricks in the browser and create a new cluster`,
-                    alwaysShow: true,
+                    alwaysShow: false,
                 },
                 {
                     label: "",
@@ -196,7 +196,7 @@ export class ConnectionCommands implements Disposable {
                 {
                     label: "Create New Repo",
                     detail: `Open Databricks in the browser and create a new repo under /Repo/${me}`,
-                    alwaysShow: true,
+                    alwaysShow: false,
                 },
                 {
                     label: "",

packages/databricks-vscode/src/configuration/ConnectionManager.ts

@@ -318,7 +318,7 @@ export class ConnectionManager {
                 e
             );
             window.showErrorMessage(
-                `Error in attaching cluster destination ${
+                `Error in attaching cluster ${
                     typeof cluster === "string" ? cluster : cluster.id
                 }`
             );