add conformance test suite#291
Open
anuraaga wants to merge 3 commits into
Open
Conversation
Co-authored-by: flaque <evan@sfcompute.com> Signed-off-by: Anuraag Agrawal <anuraaga@gmail.com>
5b1bcdf to
3b8df7d
Compare
Signed-off-by: Anuraag Agrawal <anuraaga@gmail.com>
df1728d to
ad569f5
Compare
Member
|
Hey @anuraaga, |
Signed-off-by: Anuraag Agrawal <anuraaga@gmail.com>
Author
|
Great idea @alexsnaps updated to that. I left out an error expectation since the message doesn't matter for the test, just whether it fails or not. |
Member
|
Sorry, somewhat slow following up on this, but haven't lost track of this PR 🙏 |
12 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This continues from #251 to hopefully get into a shape that can be merged, and then iterated to add more features / fixes to pass more of the conformance test.
I have redesigned things quite a bit to address feedback and simplify (IMO) things
generate.rsscript for doing all preprocessing of cel-spec.build.rsonly checks for version mismatch and fails the build if there is one#[ignored]. In the future, let's make this file empty!AI disclaimer: I used AI for autocomplete and also to generate much logic that is mostly just string crushing. I read every single line and cleaned up / rewrote significant parts - for better or worse, I stand by each line of code.