Windows Electron: NodeAPI.dll fails to load due to missing delay hook (#3)

### Description

When using node-swift to build native modules for Electron on Windows, the module fails to load because `NodeAPI.dll` imports from `node.exe` using delay-load, but the delay-load hook that redirects `node.exe` to the actual host executable is not linked into `NodeAPI.dll`.

### Root Cause

The delay-load hook (`win_delay_load_hook.cc`) is part of the `NodeModuleSupport` target, which gets linked into the final native module (e.g., `NativeRecording.node`). However, when `NodeAPI` is built as a dynamic library (`NodeAPI.dll`), it's this DLL that actually imports from `node.exe` - not the final module.

Since `NodeAPI.dll` doesn't include the delay-load hook, when the DLL loader tries to resolve `node.exe` imports, it fails because:
1. The host executable is named differently (e.g., `electron.exe`)
2. There's no hook to redirect the import to the current process

### Technical Details

- `NodeAPI.dll` has `node.exe` in its delay import table (correctly configured with `/DELAYLOAD:node.exe`)
- `__pfnDliNotifyHook2` in `NodeAPI.dll` is `NULL` (no hook registered)
- The hook exists in `NativeRecording.node` but that doesn't help since `NodeAPI.dll` is the one importing from `node.exe`

### Proposed Fix

Create a separate target `CNodeDelayLoadHook` containing only the delay-load hook code, and make `NodeAPI` depend on it (Windows only):

```swift
// In Package.swift targets array:
.target(
    name: "CNodeDelayLoadHook",
    path: "Sources/CNodeDelayLoadHook",
    sources: ["win_delay_load_hook.cc"],
    publicHeadersPath: "include",
    linkerSettings: [
        .linkedLibrary("delayimp", .when(platforms: [.windows])),
    ]
),

// Modify NodeAPI target:
.target(
    name: "NodeAPI",
    dependencies: [
        "CNodeAPI",
        "CNodeAPISupport",
        "NodeAPIMacros",
        .target(name: "CNodeDelayLoadHook", condition: .when(platforms: [.windows])),
    ],
    linkerSettings: [
        .unsafeFlags(["-Xlinker", "/DELAYLOAD:node.exe"], .when(platforms: [.windows])),
    ]
),
```

Note: We cannot simply make `NodeAPI` depend on `NodeModuleSupport` because that creates a circular dependency (`NodeModuleSupport/register.c` calls `node_swift_register` which is defined in `NodeAPI`).

### Additional Notes

The existing `win_delay_load_hook.cc` uses `#ifdef _MSC_VER` which excludes Clang. Since Swift on Windows uses Clang (targeting MSVC ABI), the guard should be changed to `#if defined(_WIN32)` or the separate hook file should omit this guard entirely.

Author: arguiot

Package.swift

@@ -46,6 +46,15 @@ let package = Package(
             ]
         ),
         .target(name: "CNodeAPISupport"),
+        .target(
+            name: "CNodeDelayLoadHook",
+            path: "Sources/CNodeDelayLoadHook",
+            sources: ["win_delay_load_hook.cc"],
+            publicHeadersPath: "include",
+            linkerSettings: [
+                .linkedLibrary("delayimp", .when(platforms: [.windows])),
+            ]
+        ),
         .macro(
             name: "NodeAPIMacros",
             dependencies: [
@@ -55,7 +64,15 @@ let package = Package(
         ),
         .target(
             name: "NodeAPI",
-            dependencies: ["CNodeAPI", "CNodeAPISupport", "NodeAPIMacros"]
+            dependencies: [
+                "CNodeAPI",
+                "CNodeAPISupport",
+                "NodeAPIMacros",
+                .target(name: "CNodeDelayLoadHook", condition: .when(platforms: [.windows])),
+            ],
+            linkerSettings: [
+                .unsafeFlags(["-Xlinker", "/DELAYLOAD:node.exe"], .when(platforms: [.windows])),
+            ]
         ),
         .target(
             name: "NodeModuleSupport",

Sources/CNodeDelayLoadHook/include/.keep

@@ -0,0 +1,24 @@
+(The MIT License)
+
+Copyright (c) 2012 Nathan Rajlich <nathan@tootallnate.net>
+
+Permission is hereby granted, free of charge, to any person
+obtaining a copy of this software and associated documentation
+files (the "Software"), to deal in the Software without
+restriction, including without limitation the rights to use,
+copy, modify, merge, publish, distribute, sublicense, and/or sell
+copies of the Software, and to permit persons to whom the
+Software is furnished to do so, subject to the following
+conditions:
+
+The above copyright notice and this permission notice shall be
+included in all copies or substantial portions of the Software.
+
+THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
+EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES
+OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
+NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT
+HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY,
+WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
+FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
+OTHER DEALINGS IN THE SOFTWARE.

Sources/CNodeDelayLoadHook/node_gyp_LICENSE

@@ -0,0 +1,41 @@
+// from node-gyp (see node_gyp_LICENSE)
+
+/*
+ * When this file is linked to a DLL, it sets up a delay-load hook that
+ * intervenes when the DLL is trying to load the host executable
+ * dynamically. Instead of trying to locate the .exe file it'll just
+ * return a handle to the process image.
+ *
+ * This allows compiled addons to work when the host executable is renamed.
+ */
+
+#if defined(_WIN32)
+
+#pragma managed(push, off)
+
+#ifndef WIN32_LEAN_AND_MEAN
+#define WIN32_LEAN_AND_MEAN
+#endif
+
+#include <windows.h>
+
+#include <delayimp.h>
+#include <string.h>
+
+static FARPROC WINAPI load_exe_hook(unsigned int event, DelayLoadInfo* info) {
+  HMODULE m;
+  if (event != dliNotePreLoadLibrary)
+    return NULL;
+
+  if (_stricmp(info->szDll, "node.exe") != 0)
+    return NULL;
+
+  m = GetModuleHandle(NULL);
+  return (FARPROC) m;
+}
+
+decltype(__pfnDliNotifyHook2) __pfnDliNotifyHook2 = load_exe_hook;
+
+#pragma managed(pop)
+
+#endif

Sources/CNodeDelayLoadHook/win_delay_load_hook.cc

@@ -1,7 +1,10 @@
 {
-  "name": "node-swift",
-  "version": "1.4.0",
+  "name": "@circleback/node-swift",
+  "version": "1.4.1",
   "repository": "kabiroberai/node-swift",
+  "publishConfig": {
+    "access": "restricted"
+  },
   "description": "Support for creating Node modules in Swift",
   "bin": "./lib/cli.js",
   "main": "./lib/builder.js",