Adjust JWT expiration interval - #572
Merged
Merged
Conversation
Setting the JWT expiration interval to the maximum allowed time of 60 seconds is not advisable, since the Box API server will actually reject a JWT assertion if the exp claim is too far in the future. Clock drift between the SDK and API of even a few seconds could then cause the JWT to be rejected. Setting the expiration interval to 30 seconds instead should maximum the amount of clock drift allowable before a JWT would get rejected, reducing the chances of an error.
|
Verified that @mattwiller has signed the CLA. Thanks for the pull request! |
carycheng
approved these changes
Mar 22, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Setting the JWT expiration interval to the maximum allowed time of
60 seconds is not advisable, since the Box API server will actually
reject a JWT assertion if the exp claim is too far in the future.
Clock drift between the SDK and API of even a few seconds could
then cause the JWT to be rejected. Setting the expiration
interval to 30 seconds instead should maximum the amount of clock
drift allowable before a JWT would get rejected, reducing the
chances of an error.