Skip to content

fix: Fix parsing content length header - #1292

Merged
congminh1254 merged 2 commits into
mainfrom
fix-content-length-header
Feb 24, 2025
Merged

congminh1254 merged 2 commits into
mainfrom
fix-content-length-header

Conversation

@congminh1254

Copy link
Copy Markdown
Member

No description provided.

@coveralls

coveralls commented Feb 24, 2025

Copy link
Copy Markdown

Pull Request Test Coverage Report for Build #4458

Details

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.05%) to 72.007%

Totals Coverage Status
Change from base Build #4450: 0.05%
Covered Lines: 8198
Relevant Lines: 11385

💛 - Coveralls

@coveralls

Copy link
Copy Markdown

Pull Request Test Coverage Report for Build #4455

Details

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.05%) to 72.007%

Totals Coverage Status
Change from base Build #4450: 0.05%
Covered Lines: 8198
Relevant Lines: 11385

💛 - Coveralls

@coveralls

coveralls commented Feb 24, 2025

Copy link
Copy Markdown

Pull Request Test Coverage Report for Build #4464

Details

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.05%) to 72.005%

Files with Coverage Reduction New Missed Lines %
src/main/java/com/box/sdk/RealtimeServerConnection.java 1 77.78%
Totals Coverage Status
Change from base Build #4450: 0.05%
Covered Lines: 8192
Relevant Lines: 11377

💛 - Coveralls


@Test
public void testLargeBinaryResponseContentLength() {
long contentLength = 2352815193L;

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is this magic number? You want it to be larger than MAX int? Some random value?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a number bigger than Max Int and which is customer having issue with, can be also considered as a random number :/

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So why not putting there this explicitly Integer.MAX_VALUE + 100?

@antusus antusus left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@congminh1254
congminh1254 merged commit 3bcf788 into main Feb 24, 2025
@congminh1254
congminh1254 deleted the fix-content-length-header branch February 24, 2025 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants