Skip to content

feat: Support downloading file from shared link - #1282

Merged
congminh1254 merged 4 commits into
mainfrom
support-downloading-file-by-shared-link
Dec 16, 2024
Merged

congminh1254 merged 4 commits into
mainfrom
support-downloading-file-by-shared-link

Conversation

@lukaszsocha2

Copy link
Copy Markdown
Contributor

No description provided.

@coveralls

coveralls commented Dec 9, 2024

Copy link
Copy Markdown

Pull Request Test Coverage Report for Build #4291

Details

  • 19 of 23 (82.61%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.1%) to 71.868%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/main/java/com/box/sdk/BoxItem.java 6 7 85.71%
src/main/java/com/box/sdk/BoxFile.java 13 16 81.25%
Totals Coverage Status
Change from base Build #4267: 0.1%
Covered Lines: 8111
Relevant Lines: 11286

💛 - Coveralls

@lukaszsocha2 lukaszsocha2 changed the title feat: Support downloading file by shared link feat: Support downloading file from shared link Dec 9, 2024
congminh1254
congminh1254 previously approved these changes Dec 11, 2024

@congminh1254 congminh1254 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@congminh1254
congminh1254 force-pushed the support-downloading-file-by-shared-link branch from 56ff4f3 to 935cb2f Compare December 12, 2024 14:55

@Pask423 Pask423 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@congminh1254
congminh1254 merged commit 9b7f28b into main Dec 16, 2024
@congminh1254
congminh1254 deleted the support-downloading-file-by-shared-link branch December 16, 2024 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants