Skip to content

feat: Support login_required, password, suppress_nofitications, verification_phone_number and additional_info fields in sign request - #1250

Merged
arjankowski merged 4 commits into
mainfrom
sign-suppress-notification
Jun 6, 2024
Merged

arjankowski merged 4 commits into
mainfrom
sign-suppress-notification

Conversation

@congminh1254

@congminh1254 congminh1254 commented Jun 4, 2024

Copy link
Copy Markdown
Member

Closes: SDK-3826

@coveralls

coveralls commented Jun 4, 2024

Copy link
Copy Markdown

Pull Request Test Coverage Report for Build #3828

Details

  • 31 of 32 (96.88%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.1%) to 72.149%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/main/java/com/box/sdk/BoxSignRequestSigner.java 23 24 95.83%
Totals Coverage Status
Change from base Build #3817: 0.1%
Covered Lines: 7642
Relevant Lines: 10592

💛 - Coveralls

@congminh1254 congminh1254 changed the title feat: Support login_required, password, suppress_nofitications and verification_phone_number fields in sign request feat: Support login_required, password, suppress_nofitications, verification_phone_number and additional_info fields in sign request Jun 5, 2024
@arjankowski

Copy link
Copy Markdown
Contributor

@congminh1254 shouldn't we also add here a new webhooks in BoxWebHook.java file?

* SIGN.REQUEST.SIGNATURE_REQUESTED
* SIGN.REQUEST.SIGNER_SIGNED
* SIGN.REQUEST.ERROR_FINALIZING

@congminh1254
congminh1254 force-pushed the sign-suppress-notification branch from 295a9f0 to daf9f8b Compare June 6, 2024 10:06

@arjankowski arjankowski left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@arjankowski
arjankowski merged commit 3ee55b3 into main Jun 6, 2024
@arjankowski
arjankowski deleted the sign-suppress-notification branch June 6, 2024 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants