Skip to content

fix: Support create empty shared link - #1241

Merged
congminh1254 merged 4 commits into
mainfrom
fix-create-empty-shared-link
Mar 29, 2024
Merged

fix: Support create empty shared link#1241
congminh1254 merged 4 commits into
mainfrom
fix-create-empty-shared-link

Conversation

@congminh1254

@congminh1254 congminh1254 commented Mar 28, 2024

Copy link
Copy Markdown
Member

No description provided.

@congminh1254
congminh1254 requested a review from antusus March 28, 2024 12:42
antusus
antusus previously approved these changes Mar 28, 2024
View reviewed changes

@antusus antusus left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@coveralls

coveralls commented Mar 28, 2024

Copy link
Copy Markdown

Pull Request Test Coverage Report for Build #3672

Details

  • 4 of 4 (100.0%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.003%) to 71.982%
Files with Coverage Reduction New Missed Lines %
src/main/java/com/box/sdk/RealtimeServerConnection.java 1 77.78%
Totals Coverage Status
Change from base Build #3654: 0.003%
Covered Lines: 7502
Relevant Lines: 10422
💛 - Coveralls

@coveralls

coveralls commented Mar 28, 2024 •
edited
Loading

Copy link
Copy Markdown

Pull Request Test Coverage Report for Build #3681

Details

  • 4 of 4 (100.0%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.009%) to 71.988%
Files with Coverage Reduction New Missed Lines %
src/main/java/com/box/sdk/RealtimeServerConnection.java 1 77.78%
Totals Coverage Status
Change from base Build #3654: 0.009%
Covered Lines: 7504
Relevant Lines: 10424
💛 - Coveralls

antusus
antusus reviewed Mar 28, 2024
View reviewed changes
Comment thread src/test/java/com/box/sdk/BoxSharedLinkTest.java
antusus
antusus approved these changes Mar 29, 2024
View reviewed changes

@antusus antusus left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@congminh1254
congminh1254 merged commit 0c86487 into main Mar 29, 2024
@congminh1254
congminh1254 deleted the fix-create-empty-shared-link branch March 29, 2024 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@antusus antusus antusus approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@congminh1254 @coveralls @antusus