Skip to content

fix: fix not closing response body - #1208

Merged
lukaszsocha2 merged 2 commits into
mainfrom
fix-not-closing-response-body-error
Sep 26, 2023
Merged

lukaszsocha2 merged 2 commits into
mainfrom
fix-not-closing-response-body-error

Conversation

@lukaszsocha2

Copy link
Copy Markdown
Contributor

No description provided.

@lukaszsocha2
lukaszsocha2 force-pushed the fix-not-closing-response-body-error branch from eae19af to 359f8d6 Compare September 26, 2023 13:33
@lukaszsocha2
lukaszsocha2 force-pushed the fix-not-closing-response-body-error branch from 359f8d6 to 0704d13 Compare September 26, 2023 13:43
@coveralls

Copy link
Copy Markdown

Pull Request Test Coverage Report for Build #3320

  • 6 of 6 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.005%) to 71.563%

Totals Coverage Status
Change from base Build #3308: 0.005%
Covered Lines: 7429
Relevant Lines: 10381

💛 - Coveralls

@coveralls

coveralls commented Sep 26, 2023

Copy link
Copy Markdown

Pull Request Test Coverage Report for Build #3336

  • 6 of 6 (100.0%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.003%) to 71.539%

Files with Coverage Reduction New Missed Lines %
src/main/java/com/box/sdk/RealtimeServerConnection.java 1 77.78%
Totals Coverage Status
Change from base Build #3326: 0.003%
Covered Lines: 7435
Relevant Lines: 10393

💛 - Coveralls

@lukaszsocha2 lukaszsocha2 changed the title [WIP] fix not closing response body fix: fix not closing response body Sep 26, 2023

@antusus antusus left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch!

@lukaszsocha2
lukaszsocha2 merged commit ab5e170 into main Sep 26, 2023
@lukaszsocha2
lukaszsocha2 deleted the fix-not-closing-response-body-error branch September 26, 2023 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants