feat: Getting collaborators allows to specify fields - #1178
Conversation
| ByteArrayOutputStream outputStream = new ByteArrayOutputStream(); | ||
| file.getRepresentationContent(representationHint, outputStream); | ||
| byte[] downloadedRepresentationContent = outputStream.toByteArray(); | ||
| Retry.retry(() -> { |
There was a problem hiding this comment.
This fails sometimes so retrying usually solves issue.
| * Can be used to override the URL used for file download. | ||
| * @return URL for file downalod | ||
| */ | ||
| protected URL getDownloadUrl() { |
There was a problem hiding this comment.
This of our internal use when we want to change download URL
Pull Request Test Coverage Report for Build #3031
💛 - Coveralls |
Pull Request Test Coverage Report for Build #3020
💛 - Coveralls |
| * @return a collection of pending collaboration infos. | ||
| */ | ||
| public static Collection<Info> getPendingCollaborations(BoxAPIConnection api) { | ||
| URL url = PENDING_COLLABORATIONS_URL.build(api.getBaseURL()); |
There was a problem hiding this comment.
is PENDING_COLLABORATIONS_URL used now anywhere? Seems not. Constant to be removed
There was a problem hiding this comment.
This is public field. Removing it can break someone else code. I'm suggesting leaving it.
| while (repContentURLString == null) { | ||
| repContentURLString = this.pollRepInfo(representation.getInfo().getUrl()); | ||
| try { | ||
| Thread.sleep(100); |
There was a problem hiding this comment.
This is basically infinite loop that is doing as many requests as it can. Only thing that can slow it down is rate limiter. This seems like a least we could improve.
lukaszsocha2
left a comment
lukaszsocha2
left a comment
There was a problem hiding this comment.
pls address comments
| // values = new ArrayList<>(); | ||
| // values.add("two"); | ||
| // values.add("one"); | ||
| // actualMD.add("/otherMultiSelect", values); |
There was a problem hiding this comment.
Please don't commit commented code
There was a problem hiding this comment.
We have two options - uncomment it and let it fail or leave for now. Check comment on line 193. I'm talking with service owners what is going on and I'm going to fix this failing test.
4 participants
Fix #1177