fix: Logging headers when retrying request - #1164
Merged
Merged
Conversation
Pull Request Test Coverage Report for Build #2899
💛 - Coveralls |
antusus
changed the title
| //1.0 + 0.5 | ||
| double jitter = (Math.random() * (maxWindow - minWindow)) + minWindow; | ||
|
|
||
| //2^5*1000*1,5 |
Contributor
There was a problem hiding this comment.
Not necessarily 2^5 (5 changes) so this comment may be misleading. Add max 2^5*1000*1,5 or sth like that
| int exponent = this.maxAttempts - this.attemptsRemaining; | ||
| double minWindow = 1 - RANDOM_FACTOR; | ||
| double maxWindow = 1 + RANDOM_FACTOR; | ||
| //1.0 + 0.5 |
Contributor
There was a problem hiding this comment.
I'm not getting fully this comment either
| } | ||
|
|
||
| /** | ||
| * Waits for some random amount of time. |
Contributor
There was a problem hiding this comment.
Not completely random. Maybe specify that waits for amount of time calculated by exponential backoff?
lukaszsocha2
approved these changes
May 4, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.