Skip to content

fix: Stop sending not specified optional fields when creating a user - #1095

Merged
antusus merged 8 commits into
mainfrom
sdk-2589-make-optional-fields-nullable-when-creating-user
Sep 6, 2022
Merged

antusus merged 8 commits into
mainfrom
sdk-2589-make-optional-fields-nullable-when-creating-user

Conversation

@lukaszsocha2

Copy link
Copy Markdown
Contributor

Closes: SDK-2589

@coveralls

coveralls commented Sep 5, 2022

Copy link
Copy Markdown

Pull Request Test Coverage Report for Build #2063

  • 15 of 20 (75.0%) changed or added relevant lines in 3 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.0009%) to 70.055%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/main/java/com/box/sdk/internal/utils/JsonUtils.java 2 3 66.67%
src/main/java/com/box/sdk/CreateUserParams.java 0 4 0.0%
Files with Coverage Reduction New Missed Lines %
src/main/java/com/box/sdk/BoxUser.java 1 63.34%
Totals Coverage Status
Change from base Build #2018: 0.0009%
Covered Lines: 7353
Relevant Lines: 10496

💛 - Coveralls

@antusus antusus left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are making a breaking change in the API because of the CreateUserParams are now returning null. We have to show it in the title

Comment thread src/main/java/com/box/sdk/CreateUserParams.java
@lukaszsocha2 lukaszsocha2 changed the title fix: Make optional fields nullable when creating a user fix!: Make optional fields nullable when creating a user Sep 6, 2022
@lukaszsocha2 lukaszsocha2 changed the title fix!: Make optional fields nullable when creating a user fix!: Make optional fields nullable when creating a user Sep 6, 2022
@lukaszsocha2 lukaszsocha2 changed the title fix!: Make optional fields nullable when creating a user fix!: Stop sending not specified optional fields when creating a user Sep 6, 2022
@lukaszsocha2 lukaszsocha2 changed the title fix!: Stop sending not specified optional fields when creating a user fix: Stop sending not specified optional fields when creating a user Sep 6, 2022
antusus
antusus previously approved these changes Sep 6, 2022

@antusus antusus left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

antusus
antusus previously approved these changes Sep 6, 2022

@antusus antusus left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@antusus antusus left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@antusus
antusus merged commit b7d894d into main Sep 6, 2022
@antusus
antusus deleted the sdk-2589-make-optional-fields-nullable-when-creating-user branch September 6, 2022 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants