feat: Revamped setting base URLs - #1042
Merged
Merged
Conversation
arjankowski
reviewed
Apr 21, 2022
| /** | ||
| * Default authorization URL | ||
| */ | ||
| protected static final String DEFAULT_AUTHORIZATION_URL = "https://account.box.com/api/"; |
Contributor
There was a problem hiding this comment.
Maybe we should change this to DEFAULT_BASE_AUTHORIZATION_URL as this is only some part of the URL?
| private String baseURL; | ||
| private String baseUploadURL; | ||
| private String baseAppURL; | ||
| private String authorizationURL; |
Contributor
There was a problem hiding this comment.
Maybe change this to baseAuthorizationURL as we have below getAuthorizationURL() method which use this as a base URL>
| } | ||
|
|
||
| /** | ||
| * Gets the base URL that's used when sending requests to the Box API. The default value is |
Contributor
There was a problem hiding this comment.
Maybe we should mention that it returns API_VERSION as well?
Just to inform that after invoke setBaseURL getBaseURL will return a different value.
| .add("maxRetryAttempts", this.getMaxRetryAttempts()) | ||
| .add("subjectType", this.subjectType) | ||
| .add("subjectId", this.subjectId); | ||
| JsonObject state = Json.parse(super.save()).asObject(); |
| @@ -337,7 +355,7 @@ public void setBaseURL(String baseURL) { | |||
| * @return the base upload URL. | |||
Contributor
There was a problem hiding this comment.
Same as base URL, maybe we should mention that it returns API_VERSION as well?
…hey are operating on base URLs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.