Skip to content

Commit 953ad78

Browse files
authored
build!: Dropping Java 7 support (#962)
* build: updating hamcrest-library to 2.2 * build: updating mockito-core to 4.1.0 * build: upgrade gradle wrapper to 4.10.1
1 parent f7dda44 commit 953ad78

8 files changed

Lines changed: 157 additions & 194 deletions

File tree

.travis.yml

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,10 +15,9 @@ dist: trusty
1515
# Test against multiple JDKs to verify compatibility
1616
jdk:
1717
# Re-enable when TravisCI supports Gradle >= 4.3
18-
# - oraclejdk9
18+
- oraclejdk9
1919
- oraclejdk8
2020
- openjdk8
21-
- openjdk7
2221

2322
# Use JDK8 for startup, since JDK7 has issues with TLS when downloading plugins
2423
install:

build.gradle

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ apply plugin: 'signing'
1010
apply plugin: 'eclipse'
1111
apply plugin: 'idea'
1212

13-
sourceCompatibility = 1.7
13+
sourceCompatibility = 1.8
1414

1515
group = 'com.box'
1616
archivesBaseName = 'box-java-sdk'
@@ -50,20 +50,20 @@ dependencies {
5050
// Do not update to latest version, as v1.57 is needed for FIPS compliance purposes
5151
compile 'org.bouncycastle:bcpkix-jdk15on:1.57'
5252
testCompile 'junit:junit:4.13.2'
53-
testCompile 'org.hamcrest:hamcrest-library:1.3'
53+
testCompile 'org.hamcrest:hamcrest-library:2.2'
5454
testCompile 'com.github.tomakehurst:wiremock:2.27.2'
55-
testCompile 'org.mockito:mockito-core:1.9.5'
55+
testCompile 'org.mockito:mockito-core:4.1.0'
5656
testCompile 'org.slf4j:slf4j-nop:1.7.32'
5757
exampleCompile 'com.eclipsesource.minimal-json:minimal-json:0.9.5'
5858
checkstyle 'com.puppycrawl.tools:checkstyle:6.19'
5959
intTestImplementation 'junit:junit:4.13.2'
60-
intTestImplementation 'org.hamcrest:hamcrest-library:1.3'
61-
intTestImplementation 'org.mockito:mockito-core:1.9.5'
60+
intTestImplementation 'org.hamcrest:hamcrest-library:2.2'
61+
intTestImplementation 'org.mockito:mockito-core:4.1.0'
6262
}
6363

6464
compileJava {
65-
sourceCompatibility = 1.7
66-
targetCompatibility = 1.7
65+
sourceCompatibility = 1.8
66+
targetCompatibility = 1.8
6767
}
6868

6969
javadoc {

gradle/wrapper/gradle-wrapper.jar

0 Bytes
Binary file not shown.
Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
1-
#Thu Sep 09 10:02:33 CEST 2021
1+
#Tue Dec 14 13:15:46 CET 2021
22
distributionBase=GRADLE_USER_HOME
33
distributionPath=wrapper/dists
44
zipStoreBase=GRADLE_USER_HOME
55
zipStorePath=wrapper/dists
6-
distributionUrl=https\://services.gradle.org/distributions/gradle-4.0.1-bin.zip
6+
distributionUrl=https\://services.gradle.org/distributions/gradle-4.10.2-bin.zip

src/intTest/java/com/box/sdk/BoxFileIT.java

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -11,12 +11,12 @@
1111
import static com.box.sdk.UniqueTestFolder.uploadTwoFileVersionsToUniqueFolder;
1212
import static java.nio.charset.StandardCharsets.UTF_8;
1313
import static org.hamcrest.MatcherAssert.assertThat;
14+
import static org.hamcrest.Matchers.emptyOrNullString;
1415
import static org.hamcrest.Matchers.equalTo;
1516
import static org.hamcrest.Matchers.hasItem;
1617
import static org.hamcrest.Matchers.hasSize;
1718
import static org.hamcrest.Matchers.instanceOf;
1819
import static org.hamcrest.Matchers.is;
19-
import static org.hamcrest.Matchers.isEmptyOrNullString;
2020
import static org.hamcrest.Matchers.not;
2121
import static org.hamcrest.Matchers.notNullValue;
2222
import static org.hamcrest.Matchers.nullValue;
@@ -26,11 +26,11 @@
2626
import static org.junit.Assert.assertNull;
2727
import static org.junit.Assert.assertTrue;
2828
import static org.junit.Assert.fail;
29-
import static org.mockito.Matchers.anyLong;
30-
import static org.mockito.Matchers.longThat;
29+
import static org.mockito.ArgumentMatchers.anyLong;
3130
import static org.mockito.Mockito.atLeastOnce;
3231
import static org.mockito.Mockito.mock;
3332
import static org.mockito.Mockito.verify;
33+
import static org.mockito.hamcrest.MockitoHamcrest.longThat;
3434

3535
import com.box.sdk.sharedlink.BoxSharedLinkRequest;
3636
import java.io.ByteArrayInputStream;
@@ -415,7 +415,7 @@ public void deleteVersionSucceeds() {
415415
previousVersion.delete();
416416

417417
Collection<BoxFileVersion> versionsAfterRemove = uploadedFile.getVersions();
418-
assertThat(versionsAfterRemove, Matchers.<BoxFileVersion>hasSize(1));
418+
assertThat(versionsAfterRemove, Matchers.hasSize(1));
419419
} finally {
420420
this.deleteFile(uploadedFile);
421421
}
@@ -430,7 +430,7 @@ public void shouldReturnTrashedAtForADeleteVersion() {
430430
uploadedFile = uploadFileToUniqueFolder(api, fileName, "Test file");
431431
uploadedFile.uploadNewVersion(this.getFileContent("Version 2"));
432432
Collection<BoxFileVersion> versions = uploadedFile.getVersions();
433-
assertThat(versions, Matchers.<BoxFileVersion>hasSize(1));
433+
assertThat(versions, Matchers.hasSize(1));
434434

435435
BoxFileVersion version = versions.iterator().next();
436436
assertThat(version.getTrashedAt(), is(nullValue()));
@@ -606,7 +606,7 @@ public void createAndUpdateSharedLinkSucceeds() {
606606
permissions.setCanPreview(true);
607607
BoxSharedLink sharedLink = uploadedFile.createSharedLink(OPEN, null, permissions);
608608

609-
assertThat(sharedLink.getURL(), not(isEmptyOrNullString()));
609+
assertThat(sharedLink.getURL(), not(is(emptyOrNullString())));
610610

611611
sharedLink.getPermissions().setCanDownload(false);
612612
BoxFile.Info info = uploadedFile.new Info();
@@ -741,7 +741,7 @@ public void getPreviewLink() {
741741
URL uploadedFilePreviewLink = uploadedFile.getPreviewLink();
742742

743743
assertThat(uploadedFilePreviewLink, is(notNullValue()));
744-
assertThat(uploadedFilePreviewLink.toString(), not(isEmptyOrNullString()));
744+
assertThat(uploadedFilePreviewLink.toString(), not(is(emptyOrNullString())));
745745
} finally {
746746
this.deleteFile(uploadedFile);
747747
}
@@ -758,7 +758,7 @@ public void getDownloadURL() {
758758
URL uploadedFileDownloadURL = uploadedFile.getDownloadURL();
759759

760760
assertThat(uploadedFileDownloadURL, is(notNullValue()));
761-
assertThat(uploadedFileDownloadURL.toString(), not(isEmptyOrNullString()));
761+
assertThat(uploadedFileDownloadURL.toString(), not(is(emptyOrNullString())));
762762
} finally {
763763
this.deleteFile(uploadedFile);
764764
}

0 commit comments

Comments
 (0)