NODE-131, fix: add verifiers to signature (#76)

* NODE-131, fix: add pool_round to signature

* NODE-131, fix: add SigDomain

* NODE-131, fix: use concatenated bytes

* NODE-131, fix: use remove :?

Author: dnjscksdn98

Cargo.lock

@@ -104,6 +104,10 @@ pub struct SetRefundState {
 #[derive(Encode, Decode, Clone, PartialEq, Eq, RuntimeDebug, TypeInfo)]
 /// The payload used for public key submission.
 pub struct VaultKeyPreSubmission<AccountId> {
+	/// The authority Ethereum address. (Relay executive)
 	pub authority_id: AccountId,
+	/// The public keys. (all in 33 bytes)
 	pub pub_keys: Vec<Public>,
+	/// The pool round.
+	pub pool_round: PoolRound,
 }

pallets/btc-registration-pool/src/lib.rs

@@ -902,7 +902,8 @@ pub mod pallet {
 					Self::verify_authority(authority_id)?;
 
 					// verify if the signature was originated from the authority_id.
-					if !signature.verify(psbt.as_ref(), authority_id) {
+					let message = [keccak_256("UnsignedPsbt".as_bytes()).as_slice(), psbt].concat();
+					if !signature.verify(&*message, authority_id) {
 						return InvalidTransaction::BadProof.into();
 					}
 
@@ -921,7 +922,9 @@ pub mod pallet {
 					}
 
 					// verify if the signature was originated from the authority.
-					if !signature.verify(signed_psbt.as_ref(), authority_id) {
+					let message =
+						[keccak_256("SignedPsbt".as_bytes()).as_slice(), signed_psbt].concat();
+					if !signature.verify(&*message, authority_id) {
 						return InvalidTransaction::BadProof.into();
 					}
 
@@ -936,7 +939,9 @@ pub mod pallet {
 					Self::verify_authority(authority_id)?;
 
 					// verify if the signature was originated from the authority_id.
-					if !signature.verify(txid.as_ref(), authority_id) {
+					let message =
+						[keccak_256("ExecutedPsbt".as_bytes()).as_slice(), txid.as_ref()].concat();
+					if !signature.verify(&*message, authority_id) {
 						return InvalidTransaction::BadProof.into();
 					}
 
@@ -955,7 +960,9 @@ pub mod pallet {
 					}
 
 					// verify if the signature was originated from the authority_id.
-					if !signature.verify(txid.as_ref(), authority_id) {
+					let message =
+						[keccak_256("RollbackPoll".as_bytes()).as_slice(), txid.as_ref()].concat();
+					if !signature.verify(&*message, authority_id) {
 						return InvalidTransaction::BadProof.into();
 					}