Skip to content

Commit 2c1cf06

Browse files
committed
Restarting browser cont.
1 parent 5a5b0f1 commit 2c1cf06

1 file changed

Lines changed: 5 additions & 8 deletions

File tree

python/scripts/run_emscripten_tests.py

Lines changed: 5 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -207,13 +207,9 @@ def wait_for_done(self):
207207

208208
class BrowserDriver:
209209
def __init__(self, hostname, port, driver):
210-
self.hostname = hostname
211-
self.port = port
210+
self.url = f"http://{hostname}:{port}/test.html"
212211
self.driver = driver
213-
self._open_test_page()
214-
215-
def _open_test_page(self):
216-
self.driver.get(f"http://{self.hostname}:{self.port}/test.html")
212+
self.driver.get(self.url)
217213
# Chrome on CI takes longer than locally to compile.
218214
self.driver.set_script_timeout(1200)
219215

@@ -238,7 +234,7 @@ def load_arrow(self):
238234
self.driver.set_script_timeout(1200)
239235

240236
def restart_browser(self):
241-
self._open_test_page()
237+
self.driver.get(self.url)
242238

243239
def execute_python(self, code, wait_for_terminate=True):
244240
if wait_for_terminate:
@@ -299,7 +295,8 @@ def __init__(self, hostname, port):
299295
def restart_browser(self):
300296
self.driver.quit()
301297
self.driver = self._make_driver()
302-
self._open_test_page()
298+
self.driver.get(self.url)
299+
self.driver.set_script_timeout(1200)
303300

304301

305302
class FirefoxDriver(BrowserDriver):

0 commit comments

Comments
 (0)