fix: fix local evaluation poller interval issue (#26)

Author: qingzhuozhen

lib/experiment/local/client.rb

@@ -20,7 +20,7 @@ def initialize(api_key, config = nil)
                         Logger::INFO
                       end
       @fetcher = LocalEvaluationFetcher.new(api_key, @config.debug, @config.server_url)
-      @poller = FlagConfigPoller.new(@fetcher, @cache, @config.debug)
+      @poller = FlagConfigPoller.new(@fetcher, @cache, @config.debug, @config.flag_config_polling_interval_millis)
 
       raise ArgumentError, 'Experiment API key is empty' if @api_key.nil? || @api_key.empty?
     end

lib/experiment/local/config.rb

@@ -24,8 +24,8 @@ class LocalEvaluationConfig
     # @param [String] server_url The server endpoint from which to request variants.
     # @param [Hash] bootstrap The value of bootstrap.
     # @param [long] flag_config_polling_interval_millis The value of flag config polling interval in million seconds.
-    def initialize(server_url = DEFAULT_SERVER_URL, bootstrap = {},
-                   flag_config_polling_interval_millis = 30_000, debug: false)
+    def initialize(server_url: DEFAULT_SERVER_URL, bootstrap: {},
+                   flag_config_polling_interval_millis: 30_000, debug: false)
       @debug = debug || false
       @server_url = server_url
       @bootstrap = bootstrap

lib/experiment/local/poller.rb

@@ -4,7 +4,7 @@ module AmplitudeExperiment
   class FlagConfigPoller
     FLAG_CONFIG_POLLING_INTERVAL_MILLIS = 30_000
 
-    def initialize(fetcher, cache, debug, poll_interval_millis: FLAG_CONFIG_POLLING_INTERVAL_MILLIS)
+    def initialize(fetcher, cache, debug, poll_interval_millis = FLAG_CONFIG_POLLING_INTERVAL_MILLIS)
       @fetcher = fetcher
       @cache = cache
       @poll_interval_millis = poll_interval_millis
@@ -40,7 +40,7 @@ def run
       @cache.clear
       @cache.put_all(flag_configs)
       @poller_thread = Thread.new do
-        sleep @poll_interval_millis
+        sleep(@poll_interval_millis / 1000.to_f)
         run
       end
     end

spec/experiment/local/client_spec.rb

@@ -18,7 +18,7 @@ module AmplitudeExperiment
 
     describe '#evaluation' do
       it 'evaluation should return variant empty object with invalid user input' do
-        local_evaluation_client = LocalEvaluationClient.new(SERVER_API_KEY)
+        local_evaluation_client = LocalEvaluationClient.new(SERVER_API_KEY, LocalEvaluationConfig.new(flag_config_polling_interval_millis: 15_000))
         result = local_evaluation_client.evaluate({}, [])
         expect(result).to eq({})
       end