Update DetectVendorFiles.php - #868
Merged
Merged
Conversation
Contributor
|
Thanks, @dunklerfox! I think it'll just need an additional check around that code to determine if Divi is active on the site. From this search, looks like https://github.com/search?q=class_exists+ET_&type=code |
Contributor
|
(so that this code doesn't run unnecessarily for users without Divi) |
Contributor
|
@leonstafford I'm thinking about adding an advanced option with a list of dirs and turning this into a for loop over that list. |
john-shaffer
force-pushed
the
patch-1
branch
2 times, most recently
from
August 30, 2022 00:11
6d2f753 to
f93d13f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have no idea if this is the correct implementation for this. I have tested this code on a single deployment and it appears to be working correctly.