Audit landing page examples against docs#968
Merged
Merged
Conversation
📝 WalkthroughWalkthroughLanding pages across all TanStack libraries are updated with revised messaging, new code examples, and expanded framework support. Changes emphasize CLI-first workflows, typed workflows with explicit run state, and Config's Changesets integration, while consolidating code examples to focus on React patterns. ChangesLanding Pages and Documentation Updates
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.github.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/components/landing/StoreLanding.tsx`:
- Around line 103-105: The example currently shows a broad subscription via
store.subscribe(listener) which contradicts the page's "Subscriptions stay
narrow" messaging; update the example in StoreLanding.tsx to demonstrate a
selector-based subscription (i.e., subscribe to a specific slice/property rather
than the whole store) by replacing the broad call store.subscribe(listener) with
a targeted subscription using a selector (or add a brief clarifying note if you
intend to show a global subscription use-case), and ensure the example aligns
with the landing copy about narrow subscriptions.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 1e14387e-b595-4931-9d64-a92fb57e6d69
📒 Files selected for processing (17)
src/components/landing/AiLanding.tsxsrc/components/landing/CliLanding.tsxsrc/components/landing/ConfigLanding.tsxsrc/components/landing/DbLanding.tsxsrc/components/landing/DevtoolsLanding.tsxsrc/components/landing/FormLanding.tsxsrc/components/landing/HotkeysLanding.tsxsrc/components/landing/IntentLanding.tsxsrc/components/landing/PacerLanding.tsxsrc/components/landing/QueryLanding.tsxsrc/components/landing/RangerLanding.tsxsrc/components/landing/RouterLanding.tsxsrc/components/landing/StoreLanding.tsxsrc/components/landing/WorkflowLanding.tsxsrc/components/landing/codeExamples.server.tsxsrc/libraries/libraries.tssrc/utils/config.ts
Comment on lines
103
to
105
| label: 'effect', | ||
| value: 'store.subscribe(selector, listener)', | ||
| value: 'store.subscribe(listener)', | ||
| }, |
There was a problem hiding this comment.
Subscription example contradicts page messaging.
The page emphasizes "Subscriptions stay narrow" and "Let the component ask for less," but line 104 shows store.subscribe(listener) without a selector, which subscribes to all state changes rather than a specific slice. This contradicts the granular subscription messaging throughout the landing page.
Consider showing a more targeted subscription pattern that aligns with the "narrow subscriptions" theme, or clarify that this example demonstrates a different use case.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@src/components/landing/StoreLanding.tsx` around lines 103 - 105, The example
currently shows a broad subscription via store.subscribe(listener) which
contradicts the page's "Subscriptions stay narrow" messaging; update the example
in StoreLanding.tsx to demonstrate a selector-based subscription (i.e.,
subscribe to a specific slice/property rather than the whole store) by replacing
the broad call store.subscribe(listener) with a targeted subscription using a
selector (or add a brief clarifying note if you intend to show a global
subscription use-case), and ensure the example aligns with the landing copy
about narrow subscriptions.
KevinVandy
approved these changes
Jun 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation
pnpm testSummary by CodeRabbit
Documentation
Bug Fixes