Merge pull request #3 from SweetPumpkinPie/lab-3

Lab 3

Author: SweetPumpkinPie

.github/workflows/sonarcloud.yml

@@ -70,13 +70,13 @@ jobs:
         run: dotnet restore NetSdrClient.sln
       - name: Build
         run: dotnet build NetSdrClient.sln -c Release --no-restore
-      #- name: Tests with coverage (OpenCover)
-      #  run: |
-      #    dotnet test NetSdrClientAppTests/NetSdrClientAppTests.csproj -c Release --no-build `
-      #      /p:CollectCoverage=true `
-      #      /p:CoverletOutput=TestResults/coverage.xml `
-      #      /p:CoverletOutputFormat=opencover
-      #  shell: pwsh
+      - name: Tests with coverage (OpenCover)
+        run: |
+          dotnet test NetSdrClientAppTests/NetSdrClientAppTests.csproj -c Release --no-build `
+            /p:CollectCoverage=true `
+            /p:CoverletOutput=TestResults/coverage.xml `
+            /p:CoverletOutputFormat=opencover
+        shell: pwsh
       # 3) END: SonarScanner
       - name: SonarScanner End
         run: dotnet sonarscanner end /d:sonar.token="${{ secrets.SONAR_TOKEN }}"

NetSdrClientApp/Messages/NetSdrMessageHelper.cs

@@ -83,7 +83,7 @@ public static bool TranslateMessage(byte[] msg, out MsgTypes type, out ControlIt
                 msgEnumarable = msgEnumarable.Skip(_msgControlItemLength);
                 msgLength -= _msgControlItemLength;
 
-                if (Enum.IsDefined(typeof(ControlItemCodes), value))
+                if (Enum.IsDefined(typeof(ControlItemCodes), (int)value))
                 {
                     itemCode = (ControlItemCodes)value;
                 }

NetSdrClientAppTests/NetSdrClientAppTests.csproj

@@ -11,7 +11,11 @@
 
   <ItemGroup>
     <PackageReference Include="coverlet.collector" Version="6.0.0" />
-    <PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.8.0" />
+    <PackageReference Include="coverlet.msbuild" Version="8.0.1">
+      <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
+      <PrivateAssets>all</PrivateAssets>
+    </PackageReference>
+    <PackageReference Include="Microsoft.NET.Test.Sdk" Version="18.4.0" />
     <PackageReference Include="Moq" Version="4.20.72" />
     <PackageReference Include="NUnit" Version="3.14.0" />
     <PackageReference Include="NUnit.Analyzers" Version="3.9.0" />

NetSdrClientAppTests/NetSdrClientTests.cs

@@ -115,5 +115,20 @@ public async Task StopIQTest()
         Assert.That(_client.IQStarted, Is.False);
     }
 
-    //TODO: cover the rest of the NetSdrClient code here
+    [Test]
+    public async Task ChangeFrequencyAsyncTest()
+    {
+        // Arrange
+        await ConnectAsyncTest();
+        long testFrequency = 100000000; // 100 MHz
+        int testChannel = 1;
+
+        // Act
+        await _client.ChangeFrequencyAsync(testFrequency, testChannel);
+
+        // Assert
+        // Ensure the client has sent at least one message via TCP after calling the method
+        // Expect 4 calls: 3 were in ConnectAsync + 1 (new frequency change request)
+        _tcpMock.Verify(tcp => tcp.SendMessageAsync(It.IsAny<byte[]>()), Times.Exactly(4));
+    }
 }

NetSdrClientAppTests/NetSdrMessageHelperTests.cs

@@ -64,6 +64,72 @@ public void GetDataItemMessageTest()
             Assert.That(parametersBytes.Count(), Is.EqualTo(parametersLength));
         }
 
-        //TODO: add more NetSdrMessageHelper tests
+        [Test]
+        public void GetSamples_WithValid16BitData_ReturnsCorrectIntegers()
+        {
+            // Arrange
+            ushort sampleSize = 16;
+            byte[] body = new byte[] { 0x01, 0x00, 0x00, 0x01 };
+
+            // Act
+            var result = NetSdrMessageHelper.GetSamples(sampleSize, body).ToList();
+
+            // Assert
+            Assert.That(result, Has.Count.EqualTo(2));
+            Assert.That(result[0], Is.EqualTo(1));
+            Assert.That(result[1], Is.EqualTo(256));
+        }
+
+        [Test]
+        public void GetSamples_WithInvalidSampleSize_ThrowsException()
+        {
+            // Arrange
+            ushort invalidSampleSize = 64; // > 4B (32 b)
+            byte[] body = new byte[] { 0x01, 0x02 };
+
+            // Act & Assert
+            Assert.Throws<ArgumentOutOfRangeException>(() => 
+                NetSdrMessageHelper.GetSamples(invalidSampleSize, body).ToList());
+        }
+
+        [Test]
+        public void TranslateMessage_WithValidData_ReturnsTrueAndCorrectBody()
+        {
+            // Arrange
+            var type = NetSdrMessageHelper.MsgTypes.Ack;
+            var code = NetSdrMessageHelper.ControlItemCodes.RFFilter;
+            byte[] dummyParams = new byte[] { 0x01, 0x02 }; 
+            byte[] rawMessage = NetSdrMessageHelper.GetControlItemMessage(type, code, dummyParams);
+
+            // Act
+            bool success = NetSdrMessageHelper.TranslateMessage(
+                rawMessage, out var outType, out var outCode, out var seqNum, out var outBody);
+
+            // Assert
+            Assert.That(success, Is.True);
+            Assert.That(outType, Is.EqualTo(type));
+            Assert.That(outCode, Is.EqualTo(code));
+            Assert.That(outBody, Is.EquivalentTo(dummyParams));
+        }
+        
+        [Test]
+        public void TranslateMessage_WithInvalidControlItemCode_ReturnsFalse()
+        {
+            // Arrange
+            var type = NetSdrMessageHelper.MsgTypes.Ack;
+            var validCode = NetSdrMessageHelper.ControlItemCodes.ReceiverState;
+            byte[] rawMessage = NetSdrMessageHelper.GetControlItemMessage(type, validCode, Array.Empty<byte>());
+
+            rawMessage[2] = 0xFF;
+            rawMessage[3] = 0xFF;
+
+            // Act
+            bool success = NetSdrMessageHelper.TranslateMessage(
+                rawMessage, out var outType, out var outCode, out var seqNum, out var outBody);
+
+            // Assert
+            Assert.That(success, Is.False);
+            Assert.That(outCode, Is.EqualTo(NetSdrMessageHelper.ControlItemCodes.None));
+        }
     }
 }