Skip to content

Commit 75458ad

Browse files
committed
Use String overloaded DataView methods in NBTTranslator
1 parent 217c2d0 commit 75458ad

1 file changed

Lines changed: 14 additions & 16 deletions

File tree

src/main/java/org/spongepowered/common/data/persistence/NBTTranslator.java

Lines changed: 14 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -24,8 +24,6 @@
2424
*/
2525
package org.spongepowered.common.data.persistence;
2626

27-
import static org.spongepowered.api.data.persistence.DataQuery.of;
28-
2927
import com.google.common.collect.Lists;
3028
import io.leangen.geantyref.TypeToken;
3129
import net.minecraft.nbt.ByteArrayTag;
@@ -77,7 +75,7 @@ private static void containerToCompound(final DataView container, final Compound
7775
String key = entry.getKey();
7876
if (value instanceof DataView) {
7977
CompoundTag inner = new CompoundTag();
80-
NBTTranslator.containerToCompound(container.getView(DataQuery.of(entry.getKey())).get(), inner);
78+
NBTTranslator.containerToCompound(container.getView(entry.getKey()).get(), inner);
8179
compound.put(key, inner);
8280
} else if (value instanceof Boolean) {
8381
compound.put(key + NBTTranslator.BOOLEAN_IDENTIFIER, ByteTag.valueOf((Boolean) value));
@@ -182,31 +180,31 @@ private static void setInternal(Tag base, byte type, DataView view, String key)
182180
switch (type) {
183181
case Constants.NBT.TAG_BYTE:
184182
if (key.contains(NBTTranslator.BOOLEAN_IDENTIFIER)) {
185-
view.set(of(key.replace(NBTTranslator.BOOLEAN_IDENTIFIER, "")), (((ByteTag) base).getAsByte() != 0));
183+
view.set(key.replace(NBTTranslator.BOOLEAN_IDENTIFIER, ""), (((ByteTag) base).getAsByte() != 0));
186184
} else {
187-
view.set(of(key), ((ByteTag) base).getAsByte());
185+
view.set(key, ((ByteTag) base).getAsByte());
188186
}
189187
break;
190188
case Constants.NBT.TAG_SHORT:
191-
view.set(of(key), ((ShortTag) base).getAsShort());
189+
view.set(key, ((ShortTag) base).getAsShort());
192190
break;
193191
case Constants.NBT.TAG_INT:
194-
view.set(of(key), ((IntTag) base).getAsInt());
192+
view.set(key, ((IntTag) base).getAsInt());
195193
break;
196194
case Constants.NBT.TAG_LONG:
197-
view.set(of(key), ((LongTag) base).getAsLong());
195+
view.set(key, ((LongTag) base).getAsLong());
198196
break;
199197
case Constants.NBT.TAG_FLOAT:
200-
view.set(of(key), ((FloatTag) base).getAsFloat());
198+
view.set(key, ((FloatTag) base).getAsFloat());
201199
break;
202200
case Constants.NBT.TAG_DOUBLE:
203-
view.set(of(key), ((DoubleTag) base).getAsDouble());
201+
view.set(key, ((DoubleTag) base).getAsDouble());
204202
break;
205203
case Constants.NBT.TAG_BYTE_ARRAY:
206-
view.set(of(key), ((ByteArrayTag) base).getAsByteArray());
204+
view.set(key, ((ByteArrayTag) base).getAsByteArray());
207205
break;
208206
case Constants.NBT.TAG_STRING:
209-
view.set(of(key), base.getAsString());
207+
view.set(key, base.getAsString());
210208
break;
211209
case Constants.NBT.TAG_LIST:
212210
ListTag list = (ListTag) base;
@@ -216,10 +214,10 @@ private static void setInternal(Tag base, byte type, DataView view, String key)
216214
for (final Tag inbt : list) {
217215
objectList.add(NBTTranslator.fromTagBase(inbt, listType));
218216
}
219-
view.set(of(key), objectList);
217+
view.set(key, objectList);
220218
break;
221219
case Constants.NBT.TAG_COMPOUND:
222-
DataView internalView = view.createView(of(key));
220+
DataView internalView = view.createView(key);
223221
CompoundTag compound = (CompoundTag) base;
224222
for (String internalKey : compound.getAllKeys()) {
225223
Tag internalBase = compound.get(internalKey);
@@ -232,10 +230,10 @@ private static void setInternal(Tag base, byte type, DataView view, String key)
232230
}
233231
break;
234232
case Constants.NBT.TAG_INT_ARRAY:
235-
view.set(of(key), ((IntArrayTag) base).getAsIntArray());
233+
view.set(key, ((IntArrayTag) base).getAsIntArray());
236234
break;
237235
case Constants.NBT.TAG_LONG_ARRAY:
238-
view.set(of(key), ((LongArrayTag) base).getAsLongArray());
236+
view.set(key, ((LongArrayTag) base).getAsLongArray());
239237
break;
240238
default:
241239
throw new IllegalArgumentException("Unknown NBT type " + type);

0 commit comments

Comments
 (0)