Skip to content

Improve Initial Docs Experience - #6410

Merged
mjackson merged 8 commits into
remix-run:masterfrom
justsml:patch-1
Oct 25, 2018
Merged

Improve Initial Docs Experience#6410
mjackson merged 8 commits into
remix-run:masterfrom
justsml:patch-1

Conversation

@justsml

@justsml justsml commented Oct 21, 2018

Copy link
Copy Markdown
Contributor

Hi y'all, thanks to everyone for all the work that's gone into this library!!! 👍

Here's a summary of my progress so far:

  • Add simpler "basic" example for "Quick Start."
  • Enhance (previous) nested routing example from "Quick Start."
  • Add explainer text to examples.
  • Move Philosophy to lower in the nav.
  • Quick Start is default content.

RE: #6409

@justsml

justsml commented Oct 22, 2018

Copy link
Copy Markdown
Contributor Author

For completeness, here's the before and after screenshots:

Before

image

After

image

@justsml

justsml commented Oct 22, 2018

Copy link
Copy Markdown
Contributor Author

Thanks for the 👍 @pshrmn @timdorr

@mjackson
mjackson merged commit 64b4335 into remix-run:master Oct 25, 2018
@mjackson

Copy link
Copy Markdown
Member

Thanks for the PR, @justsml! This looks great. I'll deploy it now.

@mjackson

Copy link
Copy Markdown
Member

Should deploy as soon as https://travis-ci.org/ReactTraining/react-router/builds/445992237 is finished 👍

@justsml

justsml commented Oct 25, 2018

Copy link
Copy Markdown
Contributor Author

That's great news @mjackson!!!
Thanks for the merge! 👍

@justsml
justsml deleted the patch-1 branch October 25, 2018 04:21
@mjackson

Copy link
Copy Markdown
Member

Thank you for your contributions to the docs, @justsml :) A lot of people are going to benefit from the improvements you're making.

@lock lock Bot locked as resolved and limited conversation to collaborators Dec 29, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants