Skip to content

[FIX] fs_image: remove rawCacheKey invalidation - #305

Merged
OCA-git-bot merged 1 commit into
OCA:16.0from
acsone:16.0-fs_image-sbj
Dec 2, 2023
Merged

[FIX] fs_image: remove rawCacheKey invalidation#305
OCA-git-bot merged 1 commit into
OCA:16.0from
acsone:16.0-fs_image-sbj

Conversation

@sbejaoui

@sbejaoui sbejaoui commented Nov 29, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

Fix view crash when uploading an image

The rawCacheKey is appropriately managed by the base class and reflects the
record's last update datetime (write_date).
Since it lacks a setter, attempting to invalidate its value results in a view crash.
Nevertheless, the value will automatically be updated upon saving the record.

@OCA-git-bot

OCA-git-bot commented Nov 29, 2023

Copy link
Copy Markdown
Contributor

Hi @lmignon,
some modules you are maintaining are being modified, check this out!

@sbejaoui sbejaoui changed the title [FIX] fs_image: rawCacheKey is properly managed by STD [FIX] fs_image: remove rawCacheKey invalidation Nov 29, 2023
@lmignon

lmignon commented Nov 29, 2023

Copy link
Copy Markdown
Contributor

@sbejaoui can you add a fragment to include into the addon history... as it's done here https://github.com/OCA/storage/pull/304/files#diff-0c0256bf7a5f02140833fcc325442a42553aac6aaf8b013258f347d6ce2d7e8c

lmignon
lmignon reviewed Nov 30, 2023
View reviewed changes
Comment thread fs_image/static/src/views/fields/fsimage_field.esm.js
@sbejaoui
sbejaoui force-pushed the 16.0-fs_image-sbj branch 2 times, most recently from 0f57a90 to 7b3d5b6 Compare December 2, 2023 08:51
@sbejaoui

sbejaoui commented Dec 2, 2023

Copy link
Copy Markdown
Contributor Author

@sbejaoui can you add a fragment to include into the addon history... as it's done here https://github.com/OCA/storage/pull/304/files#diff-0c0256bf7a5f02140833fcc325442a42553aac6aaf8b013258f347d6ce2d7e8c

done

lmignon
lmignon requested changes Dec 2, 2023
View reviewed changes
Comment thread fs_image/readme/newsfragments/305.bugfix Outdated
@sbejaoui
[FIX] fs_image: remove rawCacheKey invalidation
50bb88e 
rawCacheKey is properly managed by STD
@sbejaoui
sbejaoui requested a review from lmignon December 2, 2023 09:09
@lmignon

lmignon commented Dec 2, 2023

Copy link
Copy Markdown
Contributor

/ocabot merge patch

@OCA-git-bot

OCA-git-bot commented Dec 2, 2023

Copy link
Copy Markdown
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 16.0-ocabot-merge-pr-305-by-lmignon-bump-patch, awaiting test results.

@OCA-git-bot
OCA-git-bot merged commit adbb461 into OCA:16.0 Dec 2, 2023
@OCA-git-bot

OCA-git-bot commented Dec 2, 2023

Copy link
Copy Markdown
Contributor

Congratulations, your PR was merged at bccc50c. Thanks a lot for contributing to OCA. ❤️

@lmignon
lmignon deleted the 16.0-fs_image-sbj branch December 2, 2023 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lmignon lmignon lmignon approved these changes

Assignees

No one assigned

Labels

merged 🎉

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sbejaoui @OCA-git-bot @lmignon