This repository was archived by the owner on Jul 15, 2023. It is now read-only.
Fixes #623 Expand ~ to os.homedir() in gopath - #768
Merged
Conversation
roblourens
reviewed
Feb 5, 2017
| if (workspaceRoot) { | ||
| inputPath = inputPath.replace(/\${workspaceRoot}/g, workspaceRoot); | ||
| } | ||
| return (process.platform === 'win32' || !inputPath.startsWith('~')) ? inputPath : path.join(os.homedir(), inputPath.substr(1)); |
Member
There was a problem hiding this comment.
Why not resolve ~ on windows?
Contributor
Author
There was a problem hiding this comment.
Because ~ being the home dir is a POSIX thing. Doesn't apply to Windows.
But I see your point, if there was a workspace setting for go path using ~ checked in to source control, then the same workspace should work on Windows machine.
Thoughts?
Member
There was a problem hiding this comment.
Windows has it too now - ~ is expanded (only in powershell), and os.homedir() returns the right thing.
Contributor
Author
There was a problem hiding this comment.
Done
roblourens
approved these changes
Feb 6, 2017
roblourens
left a comment
roblourens
left a comment
Member
There was a problem hiding this comment.
Looks good, one nit, I would switch the condition around (return inputPath.startsWith ...)
Contributor
Author
|
Sure mr. nitpicker :) Will do. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.