Keep the last used cover profile path - #3119
Conversation
Signed-off-by: Alexandre Vilain <alexandre.vilain@me.com>
|
|
| if (!coverProfilePath) { | ||
| return; | ||
| } | ||
| updateWorkspaceState(lastCoverProfilePathKey, coverProfilePath); |
There was a problem hiding this comment.
We can skip updating the state if the same value was used
Ramya Rao (ramya-rao-a)
left a comment
Ramya Rao (ramya-rao-a)
left a comment
There was a problem hiding this comment.
Looks like this is your first PR contribution to this project, Thanks & Welcome!
I have just one suggested change, please do take a look.
Ramya Rao (ramya-rao-a)
left a comment
Ramya Rao (ramya-rao-a)
left a comment
There was a problem hiding this comment.
Changing review state to wait on suggested change
Ramya Rao (ramya-rao-a)
left a comment
Ramya Rao (ramya-rao-a)
left a comment
There was a problem hiding this comment.
Pushed a change to update the workspace state only if the provided value is different from the last used path and if the provided path is valid
|
The changes here are available in the latest beta version of this extension. |
|
Hi Ramya Rao (@ramya-rao-a) ! Thanks :) |
|
This change is now available in the latest version of this extension. |
3 participants
Signed-off-by: Alexandre Vilain alexandre.vilain@me.com
Fixes #3118