^ outline to include constant & interface - #2973
Conversation
* pending merge by github.com/ramya-rao-a/go-outline, sent pull request at ramya-rao-a/go-outline#10. * `interface` to follow `struct`'s regex approach * maybe the SymbolKind for type should be TypeParameter
Ramya Rao (ramya-rao-a)
left a comment
Ramya Rao (ramya-rao-a)
left a comment
There was a problem hiding this comment.
Looks like this is your first PR contribution to this project Henry Kwan (@piengeng)
Thanks & Welcome!
Can you please update the test for outline to cover the struct and interface cases as well?
- Update the go test file for outline to include struct and interface examples
- Then update the test case for outline to check for the struct and interface in the output
|
what's the minimum command line to run the **/extension.test.ts? |
|
|
|
nvm, turns out i need to close any vscode after running |
|
I usually chose the the test related debug configuration and then run that using F5 |
|
|
||
| // const constFoo = "constBar" | ||
|
|
||
| type circle struct { |
There was a problem hiding this comment.
shouldn't this be interface and not struct?
There was a problem hiding this comment.
Ramya Rao (@ramya-rao-a) you're right, just another stupid mistake. already update to my master.
|
The build is failing at the linting step with the below error:
|
|
I've tried, too complex for me, closing instead. |
Ramya Rao (ramya-rao-a)
left a comment
Ramya Rao (ramya-rao-a)
left a comment
There was a problem hiding this comment.
No worries, I pushed 2 commits to fix the tests
|
Thanks, I've looked at the data structures generated by goOutline.ts, the
more I look at it, the more confused I've become. Initially I figure it's
just making behave like the `struct` will do. Anyway, appreciate your help
:)
…On Fri, Jan 17, 2020, 3:28 PM Ramya Rao ***@***.***> wrote:
Merged #2973 <#2973> into
master.
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
<#2973?email_source=notifications&email_token=AB6XWSB6RRKBFJWI2F3ICFLQ6FMYNA5CNFSM4KEZREM2YY3PNVWWK3TUL52HS4DFWZEXG43VMVCXMZLOORHG65DJMZUWGYLUNFXW5KTDN5WW2ZLOORPWSZGOWBBLHIY#event-2957161379>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AB6XWSGCSSV7RBXAXEVH5UTQ6FMYNANCNFSM4KEZREMQ>
.
|
3 participants
interfaceto followstruct's regex approach