This repository was archived by the owner on Jul 15, 2023. It is now read-only.
Use tsconfig.json to determine which typescript files to lint - #2524
Merged
Ramya Rao (ramya-rao-a) merged 1 commit intoJun 5, 2019
Merged
Conversation
|
|
Contributor
Author
|
I think the ci failures are the same as on master. |
Ramya Rao (ramya-rao-a)
approved these changes
Jun 5, 2019
Ramya Rao (ramya-rao-a)
left a comment
Ramya Rao (ramya-rao-a)
left a comment
Contributor
There was a problem hiding this comment.
Thanks for the PR Stuart Grigg (@stuartgrigg) and apologies for the late response.
Looks like this is your first PR contribution to this project, Thanks & Welcome!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed that the
npm run lintcommand was not covering all the typescript files in the repo and was therefore missing some linting errors. I have changed this command and thenpm run fix-lintcommand so that they use the tsconfig.json file to determine which files will be linted. I have also used the fix-lint command to fix the errors which my change had uncovered.