This repository was archived by the owner on Jul 15, 2023. It is now read-only.
wrap values choice in brackets - #2155
Merged
Ramya Rao (ramya-rao-a) merged 1 commit intoNov 28, 2018
Merged
Conversation
Ramya Rao (ramya-rao-a)
approved these changes
Nov 28, 2018
Ramya Rao (ramya-rao-a)
left a comment
Ramya Rao (ramya-rao-a)
left a comment
Contributor
There was a problem hiding this comment.
Looks like this is your first PR in this project, Thanks & Welcome!
Contributor
|
Thanks for the PR JP Moresmau (@JPMoresmau)! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2144: add brackets around the values in regexp